@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Conpherence - fix add participant / remove participant form
Summary: Ref T6713. We were dropping latest transaction ID. This should fix the "easy" part of T6713.
Test Plan: tried to add participants and it worked! (removing participants only allows yourself, but that worked too.)
Reviewers: chad, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T6713
Differential Revision: https://secure.phabricator.com/D10952
+11
-1
+11
-1
src/applications/conpherence/controller/ConpherenceUpdateController.php
+11
-1
src/applications/conpherence/controller/ConpherenceUpdateController.php
···
212
212
return id(new AphrontDialogView())
213
213
->setTitle(pht('Add Participants'))
214
214
->addHiddenInput('action', 'add_person')
215
+
->addHiddenInput(
216
+
'latest_transaction_id',
217
+
$request->getInt('latest_transaction_id'))
215
218
->appendChild($form);
216
219
}
217
220
···
241
244
return id(new AphrontDialogView())
242
245
->setTitle(pht('Remove Participants'))
243
246
->addHiddenInput('action', 'remove_person')
244
-
->addHiddenInput('__continue__', true)
245
247
->addHiddenInput('remove_person', $remove_person)
248
+
->addHiddenInput(
249
+
'latest_transaction_id',
250
+
$request->getInt('latest_transaction_id'))
251
+
->addHiddenInput('__continue__', true)
246
252
->appendChild($body);
247
253
}
248
254
···
250
256
ConpherenceThread $conpherence,
251
257
$error_view) {
252
258
259
+
$request = $this->getRequest();
253
260
$form = id(new PHUIFormLayoutView())
254
261
->appendChild($error_view)
255
262
->appendChild(
···
262
269
return id(new AphrontDialogView())
263
270
->setTitle(pht('Update Conpherence'))
264
271
->addHiddenInput('action', 'metadata')
272
+
->addHiddenInput(
273
+
'latest_transaction_id',
274
+
$request->getInt('latest_transaction_id'))
265
275
->addHiddenInput('__continue__', true)
266
276
->appendChild($form);
267
277
}