recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

PHP 8.5: Avoid null array key editing Divider item in Global menu

Summary:
Setting null as an array key is deprecated since PHP 8.5 per https://www.php.net/releases/8.5/en.php: "Using null as an array offset or when calling array_key_exists() is now deprecated. Use an empty string instead."

```
ERROR 8192: Using null as an array offset is deprecated, use an empty string instead at [/var/www/html/phorge/phorge/src/applications/transactions/editengine/PhabricatorEditEngine.php:1228]
```

Closes T16408

Test Plan: On PHP 8.5, go to http://phorge.localhost/favorites/menu/builtin/tail/ to edit an existing Divider menu item in the Global Menu

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16408

Differential Revision: https://we.phorge.it/D26605

Andre Klapper d5faf6fa dcfa4a29

+1 -1
+1 -1
src/applications/transactions/editengine/PhabricatorEditEngine.php
··· 1225 1225 } 1226 1226 1227 1227 $field_key = $field->getKey(); 1228 - if (isset($copy_fields[$field_key])) { 1228 + if ($field_key && isset($copy_fields[$field_key])) { 1229 1229 $field->readValueFromField($copy_fields[$field_key]); 1230 1230 } 1231 1231