recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PHP 8.1 "strlen(null)" exception for "/bin/conduit call" without parameter

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

This patch also fixes two similar `strlen()` occurrences in the same source file.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/conduit/management/PhabricatorConduitCallManagementWorkflow.php:44]
```

Test Plan: Run `../phorge/bin/conduit call`: Get no `strlen()` error anymore but only expected output `Usage Exception: Specify a method to call with "--method".`

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25584

Andre Klapper d630f228 98cbf5fa

+3 -3
+3 -3
src/applications/conduit/management/PhabricatorConduitCallManagementWorkflow.php
··· 41 41 $viewer = $this->getViewer(); 42 42 43 43 $method = $args->getArg('method'); 44 - if (!strlen($method)) { 44 + if (!phutil_nonempty_string($method)) { 45 45 throw new PhutilArgumentUsageException( 46 46 pht('Specify a method to call with "--method".')); 47 47 } 48 48 49 49 $input = $args->getArg('input'); 50 - if (!strlen($input)) { 50 + if (!phutil_nonempty_string($input)) { 51 51 throw new PhutilArgumentUsageException( 52 52 pht('Specify a file to read parameters from with "--input".')); 53 53 } 54 54 55 55 $as = $args->getArg('as'); 56 - if (strlen($as)) { 56 + if (phutil_nonempty_string($as)) { 57 57 $actor = id(new PhabricatorPeopleQuery()) 58 58 ->setViewer($viewer) 59 59 ->withUsernames(array($as))