@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Phriction - fix a corner case on renaming a project
Summary: if you rename a project in such a way that the old slug and the new slug are the same, there are errors when the phriction document is updated. detect this case and don't bother updating the document since there is no change. Fixes Github issue 474.
Test Plan: made a project "testTest". Viewed the wiki page. Created the wiki page. Renamed the project "TestTest". Before patch, this error'd, post patch it works!
Reviewers: epriestley
Reviewed By: epriestley
CC: Korvin, epriestley, aran
Differential Revision: https://secure.phabricator.com/D7888
+2
-2
+2
-2
src/applications/project/editor/PhabricatorProjectEditor.php
+2
-2
src/applications/project/editor/PhabricatorProjectEditor.php
···
250
250
$old_slug = $project->getFullPhrictionSlug();
251
251
$project->setName($xaction->getNewValue());
252
252
$project->setPhrictionSlug($xaction->getNewValue());
253
-
254
-
if ($xaction->getOldValue()) {
253
+
$changed_slug = $old_slug != $project->getFullPhrictionSlug();
254
+
if ($xaction->getOldValue() && $changed_slug) {
255
255
$old_document = id(new PhrictionDocument())
256
256
->loadOneWhere(
257
257
'slug = %s',