@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fixed 'Modified' link in Diffusion History View.
Summary:
'Modified' link always pointed to the latest change. Fixed the link.
Test Plan:
Tested that clicking 'Modified' took me to the correct place. Made sure that
Diffusion commit view was still working correctly.
Reviewed By: epriestley
Reviewers: epriestley
CC: jungejason, aran, epriestley
Differential Revision: 255
+8
-3
+5
-2
src/applications/diffusion/view/base/DiffusionView.php
+5
-2
src/applications/diffusion/view/base/DiffusionView.php
···
29
29
return $this->diffusionRequest;
30
30
}
31
31
32
-
final public function linkChange($change_type, $file_type, $path = null) {
32
+
final public function linkChange($change_type, $file_type, $path = null,
33
+
$commit_identifier = null) {
33
34
34
35
$text = DifferentialChangeType::getFullNameForChangeType($change_type);
35
36
if ($change_type == DifferentialChangeType::TYPE_CHILD) {
···
42
43
43
44
$drequest = $this->getDiffusionRequest();
44
45
45
-
if ($drequest->getRawCommit()) {
46
+
if ($commit_identifier) {
47
+
$commit = ';'.$commit_identifier;
48
+
} else if ($drequest->getRawCommit()) {
46
49
$commit = ';'.$drequest->getCommitURIComponent($drequest->getRawCommit());
47
50
} else {
48
51
$commit = null;
+3
-1
src/applications/diffusion/view/historytable/DiffusionHistoryTableView.php
+3
-1
src/applications/diffusion/view/historytable/DiffusionHistoryTableView.php