@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Allow double click and drag in crossreference
Summary: Also simplifies the code.
Test Plan: Clicked, selected, double clicked, double clicked and dragged.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin, s.o.butler
Differential Revision: https://secure.phabricator.com/D5048
+29
-38
+23
-23
src/__celerity_resource_map__.php
+23
-23
src/__celerity_resource_map__.php
···
1873
1873
),
1874
1874
'javelin-behavior-pholio-mock-view' =>
1875
1875
array(
1876
-
'uri' => '/res/efec5d7a/rsrc/js/application/pholio/behavior-pholio-mock-view.js',
1876
+
'uri' => '/res/18129e67/rsrc/js/application/pholio/behavior-pholio-mock-view.js',
1877
1877
'type' => 'js',
1878
1878
'requires' =>
1879
1879
array(
···
1954
1954
),
1955
1955
'javelin-behavior-repository-crossreference' =>
1956
1956
array(
1957
-
'uri' => '/res/244c5251/rsrc/js/application/repository/repository-crossreference.js',
1957
+
'uri' => '/res/4b5fab1c/rsrc/js/application/repository/repository-crossreference.js',
1958
1958
'type' => 'js',
1959
1959
'requires' =>
1960
1960
array(
···
3546
3546
'uri' => '/res/pkg/8aaacd1b/differential.pkg.css',
3547
3547
'type' => 'css',
3548
3548
),
3549
-
'95d0d865' =>
3549
+
'fafc8cdb' =>
3550
3550
array(
3551
3551
'name' => 'differential.pkg.js',
3552
3552
'symbols' =>
···
3571
3571
17 => 'javelin-behavior-differential-toggle-files',
3572
3572
18 => 'javelin-behavior-differential-user-select',
3573
3573
),
3574
-
'uri' => '/res/pkg/95d0d865/differential.pkg.js',
3574
+
'uri' => '/res/pkg/fafc8cdb/differential.pkg.js',
3575
3575
'type' => 'js',
3576
3576
),
3577
3577
'c8ce2d88' =>
···
3669
3669
'aphront-typeahead-control-css' => 'acc46105',
3670
3670
'differential-changeset-view-css' => '8aaacd1b',
3671
3671
'differential-core-view-css' => '8aaacd1b',
3672
-
'differential-inline-comment-editor' => '95d0d865',
3672
+
'differential-inline-comment-editor' => 'fafc8cdb',
3673
3673
'differential-local-commits-view-css' => '8aaacd1b',
3674
3674
'differential-results-table-css' => '8aaacd1b',
3675
3675
'differential-revision-add-comment-css' => '8aaacd1b',
···
3687
3687
'javelin-behavior-aphlict-dropdown' => 'd29c1557',
3688
3688
'javelin-behavior-aphlict-listen' => 'd29c1557',
3689
3689
'javelin-behavior-aphront-basic-tokenizer' => 'd29c1557',
3690
-
'javelin-behavior-aphront-drag-and-drop' => '95d0d865',
3691
-
'javelin-behavior-aphront-drag-and-drop-textarea' => '95d0d865',
3690
+
'javelin-behavior-aphront-drag-and-drop' => 'fafc8cdb',
3691
+
'javelin-behavior-aphront-drag-and-drop-textarea' => 'fafc8cdb',
3692
3692
'javelin-behavior-aphront-form-disable-on-submit' => 'd29c1557',
3693
3693
'javelin-behavior-audit-preview' => 'f96657b8',
3694
3694
'javelin-behavior-dark-console' => 'dca4a03d',
3695
3695
'javelin-behavior-device' => 'd29c1557',
3696
-
'javelin-behavior-differential-accept-with-errors' => '95d0d865',
3697
-
'javelin-behavior-differential-add-reviewers-and-ccs' => '95d0d865',
3698
-
'javelin-behavior-differential-comment-jump' => '95d0d865',
3699
-
'javelin-behavior-differential-diff-radios' => '95d0d865',
3700
-
'javelin-behavior-differential-dropdown-menus' => '95d0d865',
3701
-
'javelin-behavior-differential-edit-inline-comments' => '95d0d865',
3702
-
'javelin-behavior-differential-feedback-preview' => '95d0d865',
3703
-
'javelin-behavior-differential-keyboard-navigation' => '95d0d865',
3704
-
'javelin-behavior-differential-populate' => '95d0d865',
3705
-
'javelin-behavior-differential-show-more' => '95d0d865',
3706
-
'javelin-behavior-differential-toggle-files' => '95d0d865',
3707
-
'javelin-behavior-differential-user-select' => '95d0d865',
3696
+
'javelin-behavior-differential-accept-with-errors' => 'fafc8cdb',
3697
+
'javelin-behavior-differential-add-reviewers-and-ccs' => 'fafc8cdb',
3698
+
'javelin-behavior-differential-comment-jump' => 'fafc8cdb',
3699
+
'javelin-behavior-differential-diff-radios' => 'fafc8cdb',
3700
+
'javelin-behavior-differential-dropdown-menus' => 'fafc8cdb',
3701
+
'javelin-behavior-differential-edit-inline-comments' => 'fafc8cdb',
3702
+
'javelin-behavior-differential-feedback-preview' => 'fafc8cdb',
3703
+
'javelin-behavior-differential-keyboard-navigation' => 'fafc8cdb',
3704
+
'javelin-behavior-differential-populate' => 'fafc8cdb',
3705
+
'javelin-behavior-differential-show-more' => 'fafc8cdb',
3706
+
'javelin-behavior-differential-toggle-files' => 'fafc8cdb',
3707
+
'javelin-behavior-differential-user-select' => 'fafc8cdb',
3708
3708
'javelin-behavior-diffusion-commit-graph' => 'f96657b8',
3709
3709
'javelin-behavior-diffusion-pull-lastmodified' => 'f96657b8',
3710
3710
'javelin-behavior-error-log' => 'dca4a03d',
···
3720
3720
'javelin-behavior-phabricator-autofocus' => 'd29c1557',
3721
3721
'javelin-behavior-phabricator-keyboard-shortcuts' => 'd29c1557',
3722
3722
'javelin-behavior-phabricator-nav' => 'd29c1557',
3723
-
'javelin-behavior-phabricator-object-selector' => '95d0d865',
3723
+
'javelin-behavior-phabricator-object-selector' => 'fafc8cdb',
3724
3724
'javelin-behavior-phabricator-oncopy' => 'd29c1557',
3725
3725
'javelin-behavior-phabricator-remarkup-assist' => 'd29c1557',
3726
3726
'javelin-behavior-phabricator-reveal-content' => 'd29c1557',
···
3728
3728
'javelin-behavior-phabricator-tooltips' => 'd29c1557',
3729
3729
'javelin-behavior-phabricator-watch-anchor' => 'd29c1557',
3730
3730
'javelin-behavior-refresh-csrf' => 'd29c1557',
3731
-
'javelin-behavior-repository-crossreference' => '95d0d865',
3731
+
'javelin-behavior-repository-crossreference' => 'fafc8cdb',
3732
3732
'javelin-behavior-toggle-class' => 'd29c1557',
3733
3733
'javelin-behavior-workflow' => 'd29c1557',
3734
3734
'javelin-dom' => 'a69b9f1f',
···
3758
3758
'phabricator-core-css' => 'acc46105',
3759
3759
'phabricator-crumbs-view-css' => 'acc46105',
3760
3760
'phabricator-directory-css' => 'acc46105',
3761
-
'phabricator-drag-and-drop-file-upload' => '95d0d865',
3761
+
'phabricator-drag-and-drop-file-upload' => 'fafc8cdb',
3762
3762
'phabricator-dropdown-menu' => 'd29c1557',
3763
3763
'phabricator-file-upload' => 'd29c1557',
3764
3764
'phabricator-filetree-view-css' => 'acc46105',
···
3780
3780
'phabricator-prefab' => 'd29c1557',
3781
3781
'phabricator-project-tag-css' => 'e30a3fa8',
3782
3782
'phabricator-remarkup-css' => 'acc46105',
3783
-
'phabricator-shaped-request' => '95d0d865',
3783
+
'phabricator-shaped-request' => 'fafc8cdb',
3784
3784
'phabricator-side-menu-view-css' => 'acc46105',
3785
3785
'phabricator-standard-page-view' => 'acc46105',
3786
3786
'phabricator-textareautils' => 'd29c1557',
+6
-15
webroot/rsrc/js/application/repository/repository-crossreference.js
+6
-15
webroot/rsrc/js/application/repository/repository-crossreference.js
···
12
12
// constrained by the markup generated by the syntax highlighters.
13
13
14
14
function link(element, lang) {
15
-
var timeout;
16
-
17
15
JX.DOM.alterClass(element, 'repository-crossreference', true);
18
16
JX.DOM.listen(
19
17
element,
20
18
'click',
21
19
'tag:span',
22
20
function(e) {
23
-
if (window.getSelection && !window.getSelection().isCollapsed) {
24
-
return;
25
-
}
26
21
var target = e.getTarget();
27
22
var map = {nc : 'class', nf : 'function', na : null};
28
23
while (target !== document.body) {
29
24
if (JX.DOM.isNode(target, 'span') && (target.className in map)) {
30
-
timeout = setTimeout(function() {
25
+
var timeout = function() {
26
+
if (window.getSelection && !window.getSelection().isCollapsed) {
27
+
return;
28
+
}
31
29
var symbol = target.textContent || target.innerText;
32
30
var query = {
33
31
lang : lang,
···
46
44
var uri = JX.$U('/diffusion/symbol/' + symbol + '/');
47
45
uri.addQueryParams(query);
48
46
window.open(uri);
49
-
}, 250);
47
+
};
48
+
setTimeout(timeout, 250);
50
49
e.kill();
51
50
break;
52
51
}
53
52
target = target.parentNode;
54
53
}
55
-
});
56
-
57
-
JX.DOM.listen(
58
-
element,
59
-
'dblclick',
60
-
'tag:span',
61
-
function(e) {
62
-
clearTimeout(timeout);
63
54
});
64
55
}
65
56