@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an EditEngine issue with unlocking fields which can't be locked
Summary: This code should go inside the field-locking loop. Otherwise, it only applies to the last field, and fatals if there are no fields.
Test Plan: Carefuller inspection.
Reviewers: chad
Reviewed By: chad
Subscribers: 20after4
Differential Revision: https://secure.phabricator.com/D16889
+4
-4
+4
-4
src/applications/transactions/storage/PhabricatorEditEngineConfiguration.php
+4
-4
src/applications/transactions/storage/PhabricatorEditEngineConfiguration.php
···
158
158
// If we don't have an explicit value, don't make any adjustments.
159
159
break;
160
160
}
161
-
}
162
161
163
-
// If the field isn't lockable, remove any lock we applied.
164
-
if (!$field->getIsLockable()) {
165
-
$field->setIsLocked(false);
162
+
// If the field isn't lockable, remove any lock we applied.
163
+
if (!$field->getIsLockable()) {
164
+
$field->setIsLocked(false);
165
+
}
166
166
}
167
167
168
168
$fields = $this->reorderFields($fields);