@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Update people edit pages UI
Summary: Updates and clarifies UI
Test Plan: New peoples, new bots, new mailing list
Reviewers: epriestley
Reviewed By: epriestley
Spies: Korvin
Differential Revision: https://secure.phabricator.com/D18562
+7
-17
+2
-7
src/applications/people/controller/PhabricatorPeopleCreateController.php
+2
-7
src/applications/people/controller/PhabricatorPeopleCreateController.php
···
92
92
$crumbs->addTextCrumb($title);
93
93
$crumbs->setBorder(true);
94
94
95
-
$header = id(new PHUIHeaderView())
96
-
->setHeader($title)
97
-
->setHeaderIcon('fa-user');
98
-
99
95
$box = id(new PHUIObjectBoxView())
100
-
->setHeaderText(pht('User'))
101
-
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
96
+
->setHeaderText($title)
97
+
->setBackground(PHUIObjectBoxView::WHITE_CONFIG)
102
98
->setForm($form);
103
99
104
100
$guidance_context = new PhabricatorPeopleCreateGuidanceContext();
···
109
105
->newInfoView();
110
106
111
107
$view = id(new PHUITwoColumnView())
112
-
->setHeader($header)
113
108
->setFooter(
114
109
array(
115
110
$guidance,
+5
-10
src/applications/people/controller/PhabricatorPeopleNewController.php
+5
-10
src/applications/people/controller/PhabricatorPeopleNewController.php
···
132
132
->setUser($admin);
133
133
134
134
if ($is_bot) {
135
+
$title = pht('Create New Bot');
135
136
$form->appendRemarkupInstructions(
136
137
pht('You are creating a new **bot** user account.'));
137
138
} else if ($is_list) {
139
+
$title = pht('Create New Mailing List');
138
140
$form->appendRemarkupInstructions(
139
141
pht('You are creating a new **mailing list** user account.'));
140
142
} else {
143
+
$title = pht('Create New User');
141
144
$form->appendRemarkupInstructions(
142
145
pht('You are creating a new **standard** user account.'));
143
146
}
···
205
208
"`bot@yourcompany.com` if you prefer."));
206
209
}
207
210
208
-
209
-
$title = pht('Create New User');
210
-
211
211
$box = id(new PHUIObjectBoxView())
212
-
->setHeaderText(pht('User'))
212
+
->setHeaderText($title)
213
213
->setFormErrors($errors)
214
-
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
214
+
->setBackground(PHUIObjectBoxView::WHITE_CONFIG)
215
215
->setForm($form);
216
216
217
217
$crumbs = $this->buildApplicationCrumbs();
218
218
$crumbs->addTextCrumb($title);
219
219
$crumbs->setBorder(true);
220
220
221
-
$header = id(new PHUIHeaderView())
222
-
->setHeader($title)
223
-
->setHeaderIcon('fa-user');
224
-
225
221
$view = id(new PHUITwoColumnView())
226
-
->setHeader($header)
227
222
->setFooter($box);
228
223
229
224
return $this->newPage()