@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Update Diff view page to new layout
Summary: Converts Diff View, single column though.
Test Plan: Upload a new diff, review page.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D15470
+20
-7
+20
-7
src/applications/differential/controller/DifferentialDiffViewController.php
+20
-7
src/applications/differential/controller/DifferentialDiffViewController.php
···
126
126
->setRenderingReferences($refs)
127
127
->setStandaloneURI('/differential/changeset/')
128
128
->setDiff($diff)
129
+
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
129
130
->setTitle(pht('Diff %d', $diff->getID()))
130
131
->setUser($request->getUser());
131
132
133
+
$title = pht('Diff %d', $diff->getID());
132
134
$crumbs = $this->buildApplicationCrumbs();
133
-
$crumbs->addTextCrumb(pht('Diff %d', $diff->getID()));
135
+
$crumbs->addTextCrumb($title);
136
+
$crumbs->setBorder(true);
137
+
138
+
$header = id(new PHUIHeaderView())
139
+
->setHeader($title);
134
140
135
141
$prop_box = id(new PHUIObjectBoxView())
136
142
->setHeader($property_head)
143
+
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
137
144
->addPropertyList($property_view)
138
145
->setForm($form);
139
146
140
-
return $this->buildApplicationPage(
141
-
array(
142
-
$crumbs,
147
+
$view = id(new PHUITwoColumnView())
148
+
->setHeader($header)
149
+
->setMainColumn(array(
150
+
151
+
))
152
+
->setFooter(array(
143
153
$prop_box,
144
154
$table_of_contents,
145
155
$details,
146
-
),
147
-
array(
148
-
'title' => pht('Diff View'),
149
156
));
157
+
158
+
$page = $this->newPage()
159
+
->setTitle(pht('Diff View'))
160
+
->setCrumbs($crumbs)
161
+
->appendChild($view);
162
+
return $page;
150
163
}
151
164
152
165
private function loadSelectableRevisions(