@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Only prevent drag-scroll in the Y direction on workboards
Summary: This scroll lock thing prevented both X and Y scrolling, but should only prevent Y scrolling. Dragging a card to the edge to scroll left/right is fine.
Test Plan: Scrolled a workboard left/right by dragging a card to the edge.
Reviewers: chad
Reviewed By: chad
Differential Revision: https://secure.phabricator.com/D15213
+21
-14
+11
-11
resources/celerity/map.php
+11
-11
resources/celerity/map.php
···
8
8
return array(
9
9
'names' => array(
10
10
'core.pkg.css' => 'b4a7e275',
11
-
'core.pkg.js' => '771b0e84',
11
+
'core.pkg.js' => '17380dd3',
12
12
'darkconsole.pkg.js' => 'e7393ebb',
13
13
'differential.pkg.css' => '2de124c9',
14
14
'differential.pkg.js' => 'd0cd0df6',
···
447
447
'rsrc/js/application/uiexample/notification-example.js' => '8ce821c5',
448
448
'rsrc/js/core/Busy.js' => '59a7976a',
449
449
'rsrc/js/core/DragAndDropFileUpload.js' => '81f182b5',
450
-
'rsrc/js/core/DraggableList.js' => '8199fb41',
450
+
'rsrc/js/core/DraggableList.js' => '705df8d1',
451
451
'rsrc/js/core/FileUpload.js' => '680ea2c8',
452
452
'rsrc/js/core/Hovercard.js' => '1bd28176',
453
453
'rsrc/js/core/KeyboardShortcut.js' => '1ae869f2',
···
742
742
'phabricator-countdown-css' => 'e7544472',
743
743
'phabricator-dashboard-css' => 'eb458607',
744
744
'phabricator-drag-and-drop-file-upload' => '81f182b5',
745
-
'phabricator-draggable-list' => '8199fb41',
745
+
'phabricator-draggable-list' => '705df8d1',
746
746
'phabricator-fatal-config-template-css' => '8e6c6fcd',
747
747
'phabricator-feed-css' => 'ecd4ec57',
748
748
'phabricator-file-upload' => '680ea2c8',
···
1352
1352
'javelin-typeahead',
1353
1353
'javelin-uri',
1354
1354
),
1355
+
'705df8d1' => array(
1356
+
'javelin-install',
1357
+
'javelin-dom',
1358
+
'javelin-stratcom',
1359
+
'javelin-util',
1360
+
'javelin-vector',
1361
+
'javelin-magical-init',
1362
+
),
1355
1363
'70baed2f' => array(
1356
1364
'javelin-install',
1357
1365
'javelin-dom',
···
1440
1448
'javelin-util',
1441
1449
'javelin-vector',
1442
1450
'javelin-stratcom',
1443
-
),
1444
-
'8199fb41' => array(
1445
-
'javelin-install',
1446
-
'javelin-dom',
1447
-
'javelin-stratcom',
1448
-
'javelin-util',
1449
-
'javelin-vector',
1450
-
'javelin-magical-init',
1451
1451
),
1452
1452
'81f182b5' => array(
1453
1453
'javelin-install',
+1
-1
src/view/phui/PHUIWorkboardView.php
+1
-1
src/view/phui/PHUIWorkboardView.php
+9
-2
webroot/rsrc/js/core/DraggableList.js
+9
-2
webroot/rsrc/js/core/DraggableList.js
···
664
664
665
665
// In Safari, we'll eventually reach `window.document`, which is not
666
666
// sufficently node-like to support sigil tests.
667
-
var lock;
667
+
var lock = false;
668
668
if (container === window.document) {
669
669
lock = false;
670
670
} else {
671
671
// Some elements may respond to, e.g., `scrollTop` adjustment, even
672
672
// though they are not scrollable. This sigil disables adjustment
673
673
// for them.
674
-
lock = JX.Stratcom.hasSigil(container, 'lock-scroll-while-dragging');
674
+
var lock_sigil;
675
+
if (property == 'scrollTop') {
676
+
lock_sigil = 'lock-scroll-y-while-dragging';
677
+
}
678
+
679
+
if (lock_sigil) {
680
+
lock = JX.Stratcom.hasSigil(container, lock_sigil);
681
+
}
675
682
}
676
683
677
684
if (!lock) {