@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add "wide" remarkup image support for Documents
Summary: Seems to work ok, if you give `size=wide` to an image file, we blow it out a bit in DocumentPro mode.
Test Plan:
Test in Phame and Maniphest.
{F1256717}
{F1256718}
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D15840
+38
-10
+7
-7
resources/celerity/map.php
+7
-7
resources/celerity/map.php
···
7
7
*/
8
8
return array(
9
9
'names' => array(
10
-
'core.pkg.css' => '2bd78e9d',
10
+
'core.pkg.css' => '5242a859',
11
11
'core.pkg.js' => '6972d365',
12
12
'darkconsole.pkg.js' => 'e7393ebb',
13
13
'differential.pkg.css' => '7ba78475',
···
104
104
'rsrc/css/application/tokens/tokens.css' => '3d0f239e',
105
105
'rsrc/css/application/uiexample/example.css' => '528b19de',
106
106
'rsrc/css/core/core.css' => 'd0801452',
107
-
'rsrc/css/core/remarkup.css' => '6aae5360',
107
+
'rsrc/css/core/remarkup.css' => '787105d6',
108
108
'rsrc/css/core/syntax.css' => '9fd11da8',
109
109
'rsrc/css/core/z-index.css' => '5b6fcf3f',
110
110
'rsrc/css/diviner/diviner-shared.css' => 'aa3656aa',
···
128
128
'rsrc/css/phui/phui-chart.css' => '6bf6f78e',
129
129
'rsrc/css/phui/phui-crumbs-view.css' => '1a1265d4',
130
130
'rsrc/css/phui/phui-curtain-view.css' => '7148ae25',
131
-
'rsrc/css/phui/phui-document-pro.css' => '73e45fd2',
131
+
'rsrc/css/phui/phui-document-pro.css' => '8419560b',
132
132
'rsrc/css/phui/phui-document-summary.css' => '9ca48bdf',
133
-
'rsrc/css/phui/phui-document.css' => '9c71d2bf',
133
+
'rsrc/css/phui/phui-document.css' => '715aedfb',
134
134
'rsrc/css/phui/phui-feed-story.css' => 'aa49845d',
135
135
'rsrc/css/phui/phui-fontkit.css' => '9cda225e',
136
136
'rsrc/css/phui/phui-form-view.css' => '6a51768e',
···
777
777
'phabricator-object-selector-css' => '85ee8ce6',
778
778
'phabricator-phtize' => 'd254d646',
779
779
'phabricator-prefab' => 'e67df814',
780
-
'phabricator-remarkup-css' => '6aae5360',
780
+
'phabricator-remarkup-css' => '787105d6',
781
781
'phabricator-search-results-css' => '7dea472c',
782
782
'phabricator-shaped-request' => '7cbe244b',
783
783
'phabricator-side-menu-view-css' => 'dd849797',
···
821
821
'phui-crumbs-view-css' => '1a1265d4',
822
822
'phui-curtain-view-css' => '7148ae25',
823
823
'phui-document-summary-view-css' => '9ca48bdf',
824
-
'phui-document-view-css' => '9c71d2bf',
825
-
'phui-document-view-pro-css' => '73e45fd2',
824
+
'phui-document-view-css' => '715aedfb',
825
+
'phui-document-view-pro-css' => '8419560b',
826
826
'phui-feed-story-css' => 'aa49845d',
827
827
'phui-font-icon-base-css' => '6449bce8',
828
828
'phui-fontkit-css' => '9cda225e',
+8
src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php
+8
src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php
···
109
109
);
110
110
$image_class = 'phabricator-remarkup-embed-image-full';
111
111
break;
112
+
// Displays "full" in normal Remarkup, "wide" in Documents
113
+
case 'wide':
114
+
$attrs += array(
115
+
'src' => $file->getBestURI(),
116
+
'width' => $file->getImageWidth(),
117
+
);
118
+
$image_class = 'phabricator-remarkup-embed-image-wide';
119
+
break;
112
120
case 'thumb':
113
121
default:
114
122
$preview_key = PhabricatorFileThumbnailTransform::TRANSFORM_PREVIEW;
+4
-2
webroot/rsrc/css/core/remarkup.css
+4
-2
webroot/rsrc/css/core/remarkup.css
···
353
353
box-shadow: 1px 1px 2px rgba({$alphablack}, 0.20);
354
354
}
355
355
356
-
.phabricator-remarkup-embed-image-full {
356
+
.phabricator-remarkup-embed-image-full,
357
+
.phabricator-remarkup-embed-image-wide {
357
358
display: inline-block;
358
359
max-width: 100%;
359
360
}
360
361
361
-
.phabricator-remarkup-embed-image-full img {
362
+
.phabricator-remarkup-embed-image-full img,
363
+
.phabricator-remarkup-embed-image-wide img {
362
364
height: auto;
363
365
max-width: 100%;
364
366
}
+19
webroot/rsrc/css/phui/phui-document-pro.css
+19
webroot/rsrc/css/phui/phui-document-pro.css
···
141
141
margin: 16px 0 0 0;
142
142
}
143
143
144
+
.phui-document-view-pro .phabricator-remarkup-embed-image-wide {
145
+
margin-left: -200px;
146
+
margin-right: -200px;
147
+
width: auto;
148
+
}
144
149
150
+
.phui-document-view-pro .phabricator-remarkup-embed-image-wide img {
151
+
max-width: 1200px;
152
+
}
145
153
154
+
@media (max-width: 1200px) {
155
+
.phui-document-view-pro .phabricator-remarkup-embed-image-wide {
156
+
margin-left: 0;
157
+
margin-right: 0;
158
+
width: auto;
159
+
}
160
+
161
+
.phui-document-view-pro .phabricator-remarkup-embed-image-wide img {
162
+
max-width: inherit;
163
+
}
164
+
}
146
165
147
166
.phui-document-view-pro-box .phui-timeline-view {
148
167
padding: 16px 0 0 0;