recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Rename "Local" settings in Diffusion to "Storage"

Summary: Ref T2783. In Diffusion -> Edit Repository, we currently have a section called "Local" with options about where the repository is stored. The current name is misleading in a cluster environment, where storage may not actually be local. Shortly, this will also have an option for cluster storage. Call this "Storage" instead.

Test Plan: Edited a repository and poked around.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T2783

Differential Revision: https://secure.phabricator.com/D11001

epriestley d8739459 3fa519da

+16 -16
+2 -2
src/__phutil_library_map__.php
··· 556 556 'DiffusionRepositoryEditDeleteController' => 'applications/diffusion/controller/DiffusionRepositoryEditDeleteController.php', 557 557 'DiffusionRepositoryEditEncodingController' => 'applications/diffusion/controller/DiffusionRepositoryEditEncodingController.php', 558 558 'DiffusionRepositoryEditHostingController' => 'applications/diffusion/controller/DiffusionRepositoryEditHostingController.php', 559 - 'DiffusionRepositoryEditLocalController' => 'applications/diffusion/controller/DiffusionRepositoryEditLocalController.php', 560 559 'DiffusionRepositoryEditMainController' => 'applications/diffusion/controller/DiffusionRepositoryEditMainController.php', 560 + 'DiffusionRepositoryEditStorageController' => 'applications/diffusion/controller/DiffusionRepositoryEditStorageController.php', 561 561 'DiffusionRepositoryEditSubversionController' => 'applications/diffusion/controller/DiffusionRepositoryEditSubversionController.php', 562 562 'DiffusionRepositoryEditUpdateController' => 'applications/diffusion/controller/DiffusionRepositoryEditUpdateController.php', 563 563 'DiffusionRepositoryListController' => 'applications/diffusion/controller/DiffusionRepositoryListController.php', ··· 3571 3571 'DiffusionRepositoryEditDeleteController' => 'DiffusionRepositoryEditController', 3572 3572 'DiffusionRepositoryEditEncodingController' => 'DiffusionRepositoryEditController', 3573 3573 'DiffusionRepositoryEditHostingController' => 'DiffusionRepositoryEditController', 3574 - 'DiffusionRepositoryEditLocalController' => 'DiffusionRepositoryEditController', 3575 3574 'DiffusionRepositoryEditMainController' => 'DiffusionRepositoryEditController', 3575 + 'DiffusionRepositoryEditStorageController' => 'DiffusionRepositoryEditController', 3576 3576 'DiffusionRepositoryEditSubversionController' => 'DiffusionRepositoryEditController', 3577 3577 'DiffusionRepositoryEditUpdateController' => 'DiffusionRepositoryEditController', 3578 3578 'DiffusionRepositoryListController' => 'DiffusionController',
+1 -1
src/applications/diffusion/application/PhabricatorDiffusionApplication.php
··· 88 88 'actions/' => 'DiffusionRepositoryEditActionsController', 89 89 '(?P<edit>remote)/' => 'DiffusionRepositoryCreateController', 90 90 '(?P<edit>policy)/' => 'DiffusionRepositoryCreateController', 91 - 'local/' => 'DiffusionRepositoryEditLocalController', 91 + 'storage/' => 'DiffusionRepositoryEditStorageController', 92 92 'delete/' => 'DiffusionRepositoryEditDeleteController', 93 93 'hosting/' => 'DiffusionRepositoryEditHostingController', 94 94 '(?P<serve>serve)/' => 'DiffusionRepositoryEditHostingController',
+2 -2
src/applications/diffusion/controller/DiffusionRepositoryEditLocalController.php src/applications/diffusion/controller/DiffusionRepositoryEditStorageController.php
··· 1 1 <?php 2 2 3 - final class DiffusionRepositoryEditLocalController 3 + final class DiffusionRepositoryEditStorageController 4 4 extends DiffusionRepositoryEditController { 5 5 6 6 public function processRequest() { ··· 29 29 $errors = array(); 30 30 31 31 $crumbs = $this->buildApplicationCrumbs(); 32 - $crumbs->addTextCrumb(pht('Edit Local')); 32 + $crumbs->addTextCrumb(pht('Edit Storage')); 33 33 34 34 $title = pht('Edit %s', $repository->getName()); 35 35
+11 -11
src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php
··· 82 82 $this->buildSubversionActions($repository)); 83 83 } 84 84 85 - $local_properties = null; 85 + $storage_properties = null; 86 86 if ($has_local) { 87 - $local_properties = $this->buildLocalProperties( 87 + $storage_properties = $this->buildStorageProperties( 88 88 $repository, 89 - $this->buildLocalActions($repository)); 89 + $this->buildStorageActions($repository)); 90 90 } 91 91 92 92 $actions_properties = $this->buildActionsProperties( ··· 140 140 ->addPropertyList($remote_properties); 141 141 } 142 142 143 - if ($local_properties) { 143 + if ($storage_properties) { 144 144 $boxes[] = id(new PHUIObjectBoxView()) 145 - ->setHeaderText(pht('Local')) 146 - ->addPropertyList($local_properties); 145 + ->setHeaderText(pht('Storage')) 146 + ->addPropertyList($storage_properties); 147 147 } 148 148 149 149 $boxes[] = id(new PHUIObjectBoxView()) ··· 548 548 return $view; 549 549 } 550 550 551 - private function buildLocalActions(PhabricatorRepository $repository) { 551 + private function buildStorageActions(PhabricatorRepository $repository) { 552 552 $viewer = $this->getRequest()->getUser(); 553 553 554 554 $view = id(new PhabricatorActionListView()) ··· 557 557 558 558 $edit = id(new PhabricatorActionView()) 559 559 ->setIcon('fa-pencil') 560 - ->setName(pht('Edit Local')) 560 + ->setName(pht('Edit Storage')) 561 561 ->setHref( 562 - $this->getRepositoryControllerURI($repository, 'edit/local/')); 562 + $this->getRepositoryControllerURI($repository, 'edit/storage/')); 563 563 $view->addAction($edit); 564 564 565 565 return $view; 566 566 } 567 567 568 - private function buildLocalProperties( 568 + private function buildStorageProperties( 569 569 PhabricatorRepository $repository, 570 570 PhabricatorActionListView $actions) { 571 571 ··· 576 576 ->setActionList($actions); 577 577 578 578 $view->addProperty( 579 - pht('Local Path'), 579 + pht('Storage Path'), 580 580 $repository->getHumanReadableDetail('local-path')); 581 581 582 582 return $view;