@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clean up Profile Menu Item page
Summary: Cleans up the UI on the page here, uses two column layout, places actions as actionlist instead of dropdown. Changes edit pages to dialogs.
Test Plan: Add an application, divider, link, and facts to a menu page.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D17030
+32
-17
+32
-17
src/applications/search/engine/PhabricatorProfileMenuEngine.php
+32
-17
src/applications/search/engine/PhabricatorProfileMenuEngine.php
···
155
155
return $content;
156
156
}
157
157
158
+
$crumbs->setBorder(true);
159
+
158
160
return $controller->newPage()
159
-
->setTitle(pht('Profile Stuff'))
161
+
->setTitle(pht('Configure Menu'))
160
162
->setNavigation($navigation)
161
163
->setCrumbs($crumbs)
162
164
->appendChild($content);
···
628
630
->setUser($viewer);
629
631
630
632
$item_types = PhabricatorProfileMenuItem::getAllMenuItems();
633
+
$object = $this->getProfileObject();
631
634
632
-
$action_view->addAction(
635
+
$action_list = id(new PhabricatorActionListView())
636
+
->setViewer($viewer);
637
+
638
+
$action_list->addAction(
633
639
id(new PhabricatorActionView())
634
640
->setLabel(true)
635
641
->setName(pht('Add New Menu Item...')));
···
641
647
642
648
$item_key = $item_type->getMenuItemKey();
643
649
644
-
$action_view->addAction(
650
+
$action_list->addAction(
645
651
id(new PhabricatorActionView())
646
652
->setIcon($item_type->getMenuItemTypeIcon())
647
653
->setName($item_type->getMenuItemTypeName())
648
-
->setHref($this->getItemURI("new/{$item_key}/")));
654
+
->setHref($this->getItemURI("new/{$item_key}/"))
655
+
->setWorkflow(true));
649
656
}
650
657
651
-
$action_view->addAction(
658
+
$action_list->addAction(
652
659
id(new PhabricatorActionView())
653
660
->setLabel(true)
654
661
->setName(pht('Documentation')));
···
656
663
$doc_link = PhabricatorEnv::getDoclink('Profile Menu User Guide');
657
664
$doc_name = pht('Profile Menu User Guide');
658
665
659
-
$action_view->addAction(
666
+
$action_list->addAction(
660
667
id(new PhabricatorActionView())
661
668
->setIcon('fa-book')
662
669
->setHref($doc_link)
663
670
->setName($doc_name));
664
671
665
-
$action_button = id(new PHUIButtonView())
666
-
->setTag('a')
667
-
->setText(pht('Configure Menu'))
668
-
->setHref('#')
669
-
->setIcon('fa-gear')
670
-
->setDropdownMenu($action_view);
671
-
672
672
$header = id(new PHUIHeaderView())
673
673
->setHeader(pht('Profile Menu Items'))
674
-
->setSubHeader(pht('Drag tabs to reorder menu'))
675
-
->addActionLink($action_button);
674
+
->setHeaderIcon('fa-list');
676
675
677
676
$box = id(new PHUIObjectBoxView())
678
-
->setHeader($header)
677
+
->setHeaderText(pht('Navigation'))
678
+
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
679
679
->setObjectList($list);
680
680
681
-
return $box;
681
+
$panel = id(new PHUICurtainPanelView())
682
+
->appendChild($action_view);
683
+
684
+
$curtain = id(new PHUICurtainView())
685
+
->setViewer($viewer)
686
+
->setActionList($action_list);
687
+
688
+
$view = id(new PHUITwoColumnView())
689
+
->setHeader($header)
690
+
->setCurtain($curtain)
691
+
->setMainColumn(
692
+
array(
693
+
$box,
694
+
));
695
+
696
+
return $view;
682
697
}
683
698
684
699
private function buildItemNewContent($item_key) {