@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Update Nuance for handleRequest
Summary: Updates Nuance controllers
Test Plan: Read carefully, lint.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: epriestley, Korvin
Differential Revision: https://secure.phabricator.com/D13762
+22
-86
+6
-23
src/applications/nuance/controller/NuanceItemEditController.php
+6
-23
src/applications/nuance/controller/NuanceItemEditController.php
···
2
2
3
3
final class NuanceItemEditController extends NuanceController {
4
4
5
-
private $itemID;
5
+
public function handleRequest(AphrontRequest $request) {
6
+
$viewer = $request->getViewer();
7
+
$id = $request->getURIData('id');
6
8
7
-
public function setItemID($item_id) {
8
-
$this->itemID = $item_id;
9
-
return $this;
10
-
}
11
-
public function getItemID() {
12
-
return $this->itemID;
13
-
}
14
-
15
-
public function willProcessRequest(array $data) {
16
-
$this->setItemID(idx($data, 'id'));
17
-
}
18
-
19
-
public function processRequest() {
20
-
$request = $this->getRequest();
21
-
$user = $request->getUser();
22
-
23
-
$item_id = $this->getItemID();
24
-
$is_new = !$item_id;
25
-
26
-
if ($is_new) {
9
+
if (!$id) {
27
10
$item = new NuanceItem();
28
11
} else {
29
12
$item = id(new NuanceItemQuery())
30
-
->setViewer($user)
31
-
->withIDs(array($item_id))
13
+
->setViewer($viewer)
14
+
->withIDs(array($id))
32
15
->executeOne();
33
16
}
34
17
+5
-20
src/applications/nuance/controller/NuanceItemViewController.php
+5
-20
src/applications/nuance/controller/NuanceItemViewController.php
···
2
2
3
3
final class NuanceItemViewController extends NuanceController {
4
4
5
-
private $itemID;
5
+
public function handleRequest(AphrontRequest $request) {
6
+
$viewer = $request->getViewer();
7
+
$id = $request->getURIData('id');
6
8
7
-
public function setItemID($item_id) {
8
-
$this->itemID = $item_id;
9
-
return $this;
10
-
}
11
-
public function getItemID() {
12
-
return $this->itemID;
13
-
}
14
-
15
-
public function willProcessRequest(array $data) {
16
-
$this->setItemID($data['id']);
17
-
}
18
-
19
-
public function processRequest() {
20
-
$request = $this->getRequest();
21
-
$user = $request->getUser();
22
-
23
-
$item_id = $this->getItemID();
24
9
$item = id(new NuanceItemQuery())
25
-
->setViewer($user)
26
-
->withIDs(array($item_id))
10
+
->setViewer($viewer)
11
+
->withIDs(array($id))
27
12
->executeOne();
28
13
29
14
if (!$item) {
+6
-23
src/applications/nuance/controller/NuanceRequestorEditController.php
+6
-23
src/applications/nuance/controller/NuanceRequestorEditController.php
···
2
2
3
3
final class NuanceRequestorEditController extends NuanceController {
4
4
5
-
private $requestorID;
5
+
public function handleRequest(AphrontRequest $request) {
6
+
$viewer = $request->getViewer();
7
+
$id = $request->getURIData('id');
6
8
7
-
public function setRequestorID($requestor_id) {
8
-
$this->requestorID = $requestor_id;
9
-
return $this;
10
-
}
11
-
public function getRequestorID() {
12
-
return $this->requestorID;
13
-
}
14
-
15
-
public function willProcessRequest(array $data) {
16
-
$this->setRequestorID(idx($data, 'id'));
17
-
}
18
-
19
-
public function processRequest() {
20
-
$request = $this->getRequest();
21
-
$user = $request->getUser();
22
-
23
-
$requestor_id = $this->getRequestorID();
24
-
$is_new = !$requestor_id;
25
-
26
-
if ($is_new) {
9
+
if (!$id) {
27
10
$requestor = new NuanceRequestor();
28
11
29
12
} else {
30
13
$requestor = id(new NuanceRequestorQuery())
31
-
->setViewer($user)
32
-
->withIDs(array($requestor_id))
14
+
->setViewer($viewer)
15
+
->withIDs(array($id))
33
16
->executeOne();
34
17
}
35
18
+5
-20
src/applications/nuance/controller/NuanceRequestorViewController.php
+5
-20
src/applications/nuance/controller/NuanceRequestorViewController.php
···
2
2
3
3
final class NuanceRequestorViewController extends NuanceController {
4
4
5
-
private $requestorID;
5
+
public function handleRequest(AphrontRequest $request) {
6
+
$viewer = $request->getViewer();
7
+
$id = $request->getURIData('id');
6
8
7
-
public function setRequestorID($requestor_id) {
8
-
$this->requestorID = $requestor_id;
9
-
return $this;
10
-
}
11
-
public function getRequestorID() {
12
-
return $this->requestorID;
13
-
}
14
-
15
-
public function willProcessRequest(array $data) {
16
-
$this->setRequestorID($data['id']);
17
-
}
18
-
19
-
public function processRequest() {
20
-
$request = $this->getRequest();
21
-
$user = $request->getUser();
22
-
23
-
$requestor_id = $this->getRequestorID();
24
9
$requestor = id(new NuanceRequestorQuery())
25
-
->setViewer($user)
26
-
->withIDs(array($requestor_id))
10
+
->setViewer($viewer)
11
+
->withIDs(array($id))
27
12
->executeOne();
28
13
29
14
if (!$requestor) {