@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Hide "Packages" field in Diffusion Commits query form when application uninstalled
Summary: Fixes T15698
Test Plan:
1. Uninstall Packages via `/applications/view/PhabricatorPackagesApplication/`
2. Go to `/diffusion/commit/`, expand the Query form, and see that `Packages` is not shown anymore
Reviewers: O1 Blessed Committers, 20after4
Reviewed By: O1 Blessed Committers, 20after4
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Maniphest Tasks: T15698
Differential Revision: https://we.phorge.it/D25506
+3
+3
src/applications/audit/query/PhabricatorCommitSearchEngine.php
+3
src/applications/audit/query/PhabricatorCommitSearchEngine.php
···
70
70
}
71
71
72
72
protected function buildCustomSearchFields() {
73
+
$show_packages = PhabricatorApplication::isClassInstalled(
74
+
'PhabricatorPackagesApplication');
73
75
return array(
74
76
id(new PhabricatorSearchDatasourceField())
75
77
->setLabel(pht('Responsible Users'))
···
118
120
->setConduitKey('packages')
119
121
->setAliases(array('package', 'packages', 'packagePHID'))
120
122
->setDatasource(new PhabricatorOwnersPackageDatasource())
123
+
->setIsHidden(!$show_packages)
121
124
->setDescription(
122
125
pht('Find commits which affect given packages.')),
123
126
id(new PhabricatorSearchThreeStateField())