@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Removed unused validateNavigationMenuItem() from PhabricatorProfileMenuEngine
Summary:
The commit rP7bde92b9c9806c5967df617fb4e843dea315ecf7 (2016) introduced `private function validateNavigationMenuItem()`.
The only call to this method was removed in rP950e9d085b482bc3484e2066591ac07c20154c9a.
Thus remove this unused method.
Test Plan:
Read/grep the code in `PhabricatorProfileMenuEngine`.
Run also `grep -RF 'validateNavigationMenuItem' --include="*.php" .` to verify that this is an orphan method.
Reviewers: O1 Blessed Committers, valerio.bozzolan
Reviewed By: O1 Blessed Committers, valerio.bozzolan
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Differential Revision: https://we.phorge.it/D25719
-9
-9
src/applications/search/engine/PhabricatorProfileMenuEngine.php
-9
src/applications/search/engine/PhabricatorProfileMenuEngine.php
···
469
469
return $map;
470
470
}
471
471
472
-
private function validateNavigationMenuItem($item) {
473
-
if (!($item instanceof PHUIListItemView)) {
474
-
throw new Exception(
475
-
pht(
476
-
'Expected buildNavigationMenuItems() to return a list of '.
477
-
'PHUIListItemView objects, but got a surprise.'));
478
-
}
479
-
}
480
-
481
472
public function getConfigureURI() {
482
473
$mode = $this->getEditMode();
483
474