@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Route Maniphest email through the transaction core
Summary: Ref T2217. Build transaction details using transaction code.
Test Plan: See screenshot.
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Maniphest Tasks: T2217
Differential Revision: https://secure.phabricator.com/D7074
+20
-5
+18
-5
src/applications/maniphest/editor/ManiphestTransactionEditor.php
+18
-5
src/applications/maniphest/editor/ManiphestTransactionEditor.php
···
250
250
->withPHIDs($phids)
251
251
->execute();
252
252
253
-
$view = new ManiphestTransactionDetailView();
254
-
$view->setTransactionGroup($transactions);
255
-
$view->setHandles($handles);
256
-
$view->setAuxiliaryFields($this->auxiliaryFields);
257
-
list($action, $main_body) = $view->renderForEmail($with_date = false);
253
+
$main_body = array();
254
+
foreach ($transactions as $transaction) {
255
+
$main_body[] = id(clone $transaction->getModernTransaction())
256
+
->setHandles($handles)
257
+
->setRenderingTarget('text')
258
+
->getTitle();
259
+
}
260
+
261
+
foreach ($transactions as $transaction) {
262
+
if ($transaction->getComments()) {
263
+
$main_body[] = null;
264
+
$main_body[] = $transaction->getComments();
265
+
}
266
+
}
267
+
268
+
$main_body = implode("\n", $main_body);
269
+
270
+
$action = head($transactions)->getModernTransaction()->getActionName();
258
271
259
272
$is_create = $this->isCreate($transactions);
260
273