@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Update Differential edit pages to new UI
Summary: Updates using PHUITwoColumnView, new headers, etc.
Test Plan: New Diff, Update Diff, View Standalone pages, Edit pages.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D15549
+50
-29
+14
-9
src/applications/differential/controller/DifferentialChangesetViewController.php
+14
-9
src/applications/differential/controller/DifferentialChangesetViewController.php
···
275
275
->setRenderURI('/differential/changeset/')
276
276
->setDiff($diff)
277
277
->setTitle(pht('Standalone View'))
278
+
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
278
279
->setParser($parser);
279
280
280
281
if ($revision_id) {
···
296
297
}
297
298
298
299
$crumbs->addTextCrumb($changeset->getDisplayFilename());
300
+
$crumbs->setBorder(true);
299
301
300
-
return $this->buildApplicationPage(
301
-
array(
302
-
$crumbs,
303
-
$detail,
304
-
),
305
-
array(
306
-
'title' => pht('Changeset View'),
307
-
'device' => false,
308
-
));
302
+
$header = id(new PHUIHeaderView())
303
+
->setHeader(pht('Changeset View'))
304
+
->setHeaderIcon('fa-gear');
305
+
306
+
$view = id(new PHUITwoColumnView())
307
+
->setHeader($header)
308
+
->setFooter($detail);
309
+
310
+
return $this->newPage()
311
+
->setTitle(pht('Changeset View'))
312
+
->setCrumbs($crumbs)
313
+
->appendChild($view);
309
314
}
310
315
311
316
private function buildRawFileResponse(
+18
-11
src/applications/differential/controller/DifferentialDiffCreateController.php
+18
-11
src/applications/differential/controller/DifferentialDiffCreateController.php
···
124
124
$title = pht('Update Diff');
125
125
$header = pht('Update Diff');
126
126
$button = pht('Continue');
127
+
$header_icon = 'fa-upload';
127
128
} else {
128
129
$title = pht('Create Diff');
129
130
$header = pht('Create New Diff');
130
131
$button = pht('Create Diff');
132
+
$header_icon = 'fa-plus-square';
131
133
}
132
134
133
135
$form
···
180
182
->setValue($button));
181
183
182
184
$form_box = id(new PHUIObjectBoxView())
183
-
->setHeaderText($header)
185
+
->setHeaderText(pht('Diff'))
184
186
->setValidationException($validation_exception)
185
187
->setForm($form)
188
+
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
186
189
->setFormErrors($errors);
187
-
188
-
if ($info_view) {
189
-
$form_box->setInfoView($info_view);
190
-
}
191
190
192
191
$crumbs = $this->buildApplicationCrumbs();
193
192
if ($revision) {
···
196
195
'/'.$revision->getMonogram());
197
196
}
198
197
$crumbs->addTextCrumb($title);
198
+
$crumbs->setBorder(true);
199
199
200
-
return $this->buildApplicationPage(
201
-
array(
202
-
$crumbs,
200
+
$header = id(new PHUIHeaderView())
201
+
->setHeader($title)
202
+
->setHeaderIcon($header_icon);
203
+
204
+
$view = id(new PHUITwoColumnView())
205
+
->setHeader($header)
206
+
->setFooter(array(
207
+
$info_view,
203
208
$form_box,
204
-
),
205
-
array(
206
-
'title' => $title,
207
209
));
210
+
211
+
return $this->newPage()
212
+
->setTitle($title)
213
+
->setCrumbs($crumbs)
214
+
->appendChild($view);
208
215
}
209
216
210
217
}
+18
-9
src/applications/differential/controller/DifferentialRevisionEditController.php
+18
-9
src/applications/differential/controller/DifferentialRevisionEditController.php
···
171
171
$crumbs = $this->buildApplicationCrumbs();
172
172
if ($revision->getID()) {
173
173
if ($diff) {
174
+
$header_icon = 'fa-upload';
174
175
$title = pht('Update Differential Revision');
175
176
$crumbs->addTextCrumb(
176
177
'D'.$revision->getID(),
177
178
'/differential/diff/'.$diff->getID().'/');
178
179
} else {
180
+
$header_icon = 'fa-pencil';
179
181
$title = pht('Edit Differential Revision');
180
182
$crumbs->addTextCrumb(
181
183
'D'.$revision->getID(),
182
184
'/D'.$revision->getID());
183
185
}
184
186
} else {
187
+
$header_icon = 'fa-plus-square';
185
188
$title = pht('Create New Differential Revision');
186
189
}
187
190
188
191
$form_box = id(new PHUIObjectBoxView())
189
-
->setHeaderText($title)
192
+
->setHeaderText('Revision')
190
193
->setValidationException($validation_exception)
194
+
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
191
195
->setForm($form);
192
196
193
197
$crumbs->addTextCrumb($title);
198
+
$crumbs->setBorder(true);
194
199
195
-
return $this->buildApplicationPage(
196
-
array(
197
-
$crumbs,
198
-
$form_box,
199
-
),
200
-
array(
201
-
'title' => $title,
202
-
));
200
+
$header = id(new PHUIHeaderView())
201
+
->setHeader($title)
202
+
->setHeaderIcon($header_icon);
203
+
204
+
$view = id(new PHUITwoColumnView())
205
+
->setHeader($header)
206
+
->setFooter($form_box);
207
+
208
+
return $this->newPage()
209
+
->setTitle($title)
210
+
->setCrumbs($crumbs)
211
+
->appendChild($view);
203
212
}
204
213
205
214
}