@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an issue with viewing an empty board with milestone columns
Summary:
Ref T10010.
- Viewing an empty board with milestone columns did a meaningless edge query. Don't do that.
- When creating the first milestone of a parent, force the indexing engine to rematerialize it inline. This sets `hasMilestones` properly. Otherwise, the daemons may take some time to fix this in the indexer.
Test Plan:
- Viewed an empty board of a project with a milestone.
- Viewed a normal board.
- Created the first milestone of a project with a big queue of daemons, saw project state immediately fully reflect the project having milestones.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10010
Differential Revision: https://secure.phabricator.com/D15206
+7
-1
+6
src/applications/project/editor/PhabricatorProjectTransactionEditor.php
+6
src/applications/project/editor/PhabricatorProjectTransactionEditor.php
···
631
631
}
632
632
break;
633
633
case PhabricatorProjectTransaction::TYPE_PARENT:
634
+
case PhabricatorProjectTransaction::TYPE_MILESTONE:
634
635
$materialize = true;
635
636
$new_parent = $object->getParentProject();
636
637
break;
···
667
668
if ($materialize) {
668
669
id(new PhabricatorProjectsMembershipIndexEngineExtension())
669
670
->rematerialize($object);
671
+
}
672
+
673
+
if ($new_parent) {
674
+
id(new PhabricatorProjectsMembershipIndexEngineExtension())
675
+
->rematerialize($new_parent);
670
676
}
671
677
672
678
return parent::applyFinalEffects($object, $xactions);
+1
-1
src/applications/project/engine/PhabricatorBoardLayoutEngine.php
+1
-1
src/applications/project/engine/PhabricatorBoardLayoutEngine.php