@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
When a non-broadcasting revision is updated, put it in "Draft", not "Needs Review"
Summary: Depends on D19285. Ref T13110. When you update an "Abandoned + But, Never Promoted" revision or (in the future) a "Changes Planned + But, Never Promoted" revision, return it to the "Draft" state rather than promoting it.
Test Plan: Updated an "Abandoned + Draft" revision, saw it return to "Draft".
Maniphest Tasks: T13110
Differential Revision: https://secure.phabricator.com/D19286
+8
-2
+8
-2
src/applications/differential/xaction/DifferentialRevisionUpdateTransaction.php
+8
-2
src/applications/differential/xaction/DifferentialRevisionUpdateTransaction.php
···
13
13
public function applyInternalEffects($object, $value) {
14
14
$should_review = $this->shouldRequestReviewAfterUpdate($object);
15
15
if ($should_review) {
16
-
$object->setModernRevisionStatus(
17
-
DifferentialRevisionStatus::NEEDS_REVIEW);
16
+
// If we're updating a non-broadcasting revision, put it back in draft
17
+
// rather than moving it directly to "Needs Review".
18
+
if ($object->getShouldBroadcast()) {
19
+
$new_status = DifferentialRevisionStatus::NEEDS_REVIEW;
20
+
} else {
21
+
$new_status = DifferentialRevisionStatus::DRAFT;
22
+
}
23
+
$object->setModernRevisionStatus($new_status);
18
24
}
19
25
20
26
$editor = $this->getEditor();