@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Apply a TYPE_CREATE transaction when importing events to improve strings in timeline
Summary: Ref T10747. This turns on the newer EditEngine behavior so we get a nice "X created this event." transaction, instead of an "X renamed this from <nothing> to Event Name."
Test Plan: Imported an event, saw a nice timeline.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10747
Differential Revision: https://secure.phabricator.com/D16771
+15
+9
src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
+9
src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
···
11
11
return pht('Calendar');
12
12
}
13
13
14
+
public function getCreateObjectTitle($author, $object) {
15
+
return pht('%s created this event.', $author);
16
+
}
17
+
18
+
public function getCreateObjectTitleForFeed($author, $object) {
19
+
return pht('%s created %s.', $author, $object);
20
+
}
21
+
22
+
14
23
protected function shouldApplyInitialEffects(
15
24
PhabricatorLiskDAO $object,
16
25
array $xactions) {
+6
src/applications/calendar/import/PhabricatorCalendarImportEngine.php
+6
src/applications/calendar/import/PhabricatorCalendarImportEngine.php
···
471
471
$xactions = array();
472
472
$uid = $node->getUID();
473
473
474
+
if (!$event->getID()) {
475
+
$xactions[] = id(new PhabricatorCalendarEventTransaction())
476
+
->setTransactionType(PhabricatorTransactions::TYPE_CREATE)
477
+
->setNewValue(true);
478
+
}
479
+
474
480
$name = $node->getName();
475
481
if (!strlen($name)) {
476
482
if (strlen($uid)) {