recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

PHPMailer: Set defaults for required parameters followed by optional parameters in Authorise() method signature

Summary:
Required parameters $password and $username follow the optional parameter $tval.
This is deprecated since PHP 8.0 per https://www.php.net/manual/en/migration80.deprecated.php
Define defaults for those required parameters to fix the issue - https://github.com/PHPMailer/PHPMailer/blob/master/src/POP3.php#L199 seems to also have survived so far without complaints by PHP 8 users (and PHPStan also does not complain anymore after this change).

Closes T15834

Test Plan: Carefully read the code.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15834

Differential Revision: https://we.phorge.it/D25660

Andre Klapper d9e543ba 4bf5c452

+1 -1
+1 -1
externals/phpmailer/class.pop3.php
··· 142 142 * @param string $username 143 143 * @param string $password 144 144 */ 145 - public function Authorise ($host, $port = false, $tval = false, $username, $password, $debug_level = 0) { 145 + public function Authorise ($host, $port = false, $tval = false, $username = '', $password = '', $debug_level = 0) { 146 146 $this->host = $host; 147 147 148 148 // If no port value is passed, retrieve it