@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Hide skipped tests by default in Differential build result summary view
Summary: Ref T8096. Currently, we hide passing tests by default (they aren't interesting) but should also hide skipped tests by default (they aren't interesting either).
Test Plan: {F694485}
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T8096
Differential Revision: https://secure.phabricator.com/D13821
+8
-2
+8
-2
src/applications/differential/customfield/DifferentialUnitField.php
+8
-2
src/applications/differential/customfield/DifferentialUnitField.php
···
56
56
57
57
protected function newHarbormasterMessageView(array $messages) {
58
58
foreach ($messages as $key => $message) {
59
-
if ($message->getResult() == ArcanistUnitTestResult::RESULT_PASS) {
60
-
unset($messages[$key]);
59
+
switch ($message->getResult()) {
60
+
case ArcanistUnitTestResult::RESULT_PASS:
61
+
case ArcanistUnitTestResult::RESULT_SKIP:
62
+
// Don't show "Pass" or "Skip" in the UI since they aren't very
63
+
// interesting. The user can click through to the full results if
64
+
// they want details.
65
+
unset($messages[$key]);
66
+
break;
61
67
}
62
68
}
63
69