@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't mark a thread as seen if durable column is minimized
Summary: More work to do here on the JS side, but this at least makes sure users with a small chat window have some notification marked that new replies have not been seen.
Test Plan: Open two windows. Window 1 has durable minimized, Window 2 is full conpherence. Send a message from Window 2, see header count in Window 1 increase. Repeat with durable open, see no change in window.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D16650
+7
-2
+7
-2
src/applications/conpherence/controller/ConpherenceUpdateController.php
+7
-2
src/applications/conpherence/controller/ConpherenceUpdateController.php
···
607
607
$user,
608
608
$conpherence,
609
609
!$minimal_display);
610
-
$participant_obj = $conpherence->getParticipant($user->getPHID());
611
-
$participant_obj->markUpToDate($conpherence, $data['latest_transaction']);
610
+
$key = PhabricatorConpherenceColumnMinimizeSetting::SETTINGKEY;
611
+
$minimized = $user->getUserSetting($key);
612
+
if (!$minimized) {
613
+
$participant_obj = $conpherence->getParticipant($user->getPHID());
614
+
$participant_obj
615
+
->markUpToDate($conpherence, $data['latest_transaction']);
616
+
}
612
617
} else if ($need_transactions) {
613
618
$non_update = true;
614
619
$data = array();