@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Convert a low-level VCS query in Diff extraction to a Conduit call
Summary: Ref T9319. Ref T2783. This won't currently work in a future environment where daemons and repositories are not on the same host. Send it over Conduit instead.
Test Plan: Used `bin/differential attach-commit rX Dy` to force attachment, saw valid content pull over Conduit.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T2783, T9319
Differential Revision: https://secure.phabricator.com/D14969
+14
-10
+14
-10
src/applications/differential/engine/DifferentialDiffExtractionEngine.php
+14
-10
src/applications/differential/engine/DifferentialDiffExtractionEngine.php
···
142
142
return true;
143
143
}
144
144
145
-
$drequest = DiffusionRequest::newFromDictionary(array(
146
-
'user' => $viewer,
147
-
'repository' => $repository,
148
-
'commit' => $identifier,
149
-
'path' => $path,
150
-
));
145
+
$drequest = DiffusionRequest::newFromDictionary(
146
+
array(
147
+
'user' => $viewer,
148
+
'repository' => $repository,
149
+
));
151
150
152
-
$corpus = DiffusionFileContentQuery::newFromDiffusionRequest($drequest)
153
-
->setViewer(PhabricatorUser::getOmnipotentUser())
154
-
->loadFileContent()
155
-
->getCorpus();
151
+
$response = DiffusionQuery::callConduitWithDiffusionRequest(
152
+
$viewer,
153
+
$drequest,
154
+
'diffusion.filecontentquery',
155
+
array(
156
+
'commit' => $identifier,
157
+
'path' => $path,
158
+
));
159
+
$corpus = $response['corpus'];
156
160
157
161
if ($files[$file_phid]->loadFileData() != $corpus) {
158
162
return true;