@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Conpherence - fix widget updates from main view
Summary: Fixes T8217. Broken circa D12760. Some browsers rendered nothing while others rendered a ",".
Test Plan: added folks to conpherences and saw people widget update correctly. added files to conpherence and saw file widget update correctly. Tested on Chrome and Firefox.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T8217
Differential Revision: https://secure.phabricator.com/D12912
+2
-2
+2
-2
src/applications/conpherence/controller/ConpherenceUpdateController.php
+2
-2
src/applications/conpherence/controller/ConpherenceUpdateController.php
···
528
528
->setUser($this->getRequest()->getUser())
529
529
->setConpherence($conpherence)
530
530
->setUpdateURI($widget_uri);
531
-
$file_widget = $file_widget->render();
531
+
$file_widget = hsprintf('%s', $file_widget->render());
532
532
break;
533
533
case ConpherenceUpdateActions::ADD_PERSON:
534
534
$people_widget = id(new ConpherencePeopleWidgetView())
535
535
->setUser($user)
536
536
->setConpherence($conpherence)
537
537
->setUpdateURI($widget_uri);
538
-
$people_widget = $people_widget->render();
538
+
$people_widget = hsprintf('%s', $people_widget->render());
539
539
break;
540
540
case ConpherenceUpdateActions::REMOVE_PERSON:
541
541
case ConpherenceUpdateActions::NOTIFICATIONS: