@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Calendar event detail view should show no time for all day events, and should show only one time field for one day events.
Summary: Ref T8021, Calendar event detail view should show no time for all day events, and should show only one time field for one day events
Test Plan: Open all-day event, event should show "Time" field with not start/end dates. Two day events should show start and end days, not times. Normal events should show old way of displaying start and end times.
Reviewers: #blessed_reviewers, epriestley
Reviewed By: #blessed_reviewers, epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T8021
Differential Revision: https://secure.phabricator.com/D12768
+24
-6
+24
-6
src/applications/calendar/controller/PhabricatorCalendarEventViewController.php
+24
-6
src/applications/calendar/controller/PhabricatorCalendarEventViewController.php
···
179
179
->setUser($viewer)
180
180
->setObject($event);
181
181
182
-
$properties->addProperty(
183
-
pht('Starts'),
184
-
phabricator_datetime($event->getDateFrom(), $viewer));
182
+
if ($event->getIsAllDay()) {
183
+
$date_start = phabricator_date($event->getDateFrom(), $viewer);
184
+
$date_end = phabricator_date($event->getDateTo(), $viewer);
185
185
186
-
$properties->addProperty(
187
-
pht('Ends'),
188
-
phabricator_datetime($event->getDateTo(), $viewer));
186
+
if ($date_start == $date_end) {
187
+
$properties->addProperty(
188
+
pht('Time'),
189
+
phabricator_date($event->getDateFrom(), $viewer));
190
+
} else {
191
+
$properties->addProperty(
192
+
pht('Starts'),
193
+
phabricator_date($event->getDateFrom(), $viewer));
194
+
$properties->addProperty(
195
+
pht('Ends'),
196
+
phabricator_date($event->getDateTo(), $viewer));
197
+
}
198
+
} else {
199
+
$properties->addProperty(
200
+
pht('Starts'),
201
+
phabricator_datetime($event->getDateFrom(), $viewer));
202
+
203
+
$properties->addProperty(
204
+
pht('Ends'),
205
+
phabricator_datetime($event->getDateTo(), $viewer));
206
+
}
189
207
190
208
$properties->addProperty(
191
209
pht('Host'),