@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Allow workboard cards to be dragged again by using a larger value for infinity
Summary:
Fixes T11886. D16882 prevented workboard cards from being dragged between columns because it reduced the effective document height to almost nothing (~78px, just the menu bars).
Instead, use the larger of the document height and viewport height as "infinity".
Test Plan: Dragged columns between workboards successfully.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T11886
Differential Revision: https://secure.phabricator.com/D16885
+18
-13
+11
-11
resources/celerity/map.php
+11
-11
resources/celerity/map.php
···
10
10
'conpherence.pkg.css' => '0b64e988',
11
11
'conpherence.pkg.js' => '6249a1cf',
12
12
'core.pkg.css' => '2f1ecc57',
13
-
'core.pkg.js' => 'ba34ebda',
13
+
'core.pkg.js' => '56f967a5',
14
14
'darkconsole.pkg.js' => 'e7393ebb',
15
15
'differential.pkg.css' => 'a4ba74b5',
16
16
'differential.pkg.js' => '634399e9',
···
471
471
'rsrc/js/application/uiexample/notification-example.js' => '8ce821c5',
472
472
'rsrc/js/core/Busy.js' => '59a7976a',
473
473
'rsrc/js/core/DragAndDropFileUpload.js' => '58dea2fa',
474
-
'rsrc/js/core/DraggableList.js' => '5a13c79f',
474
+
'rsrc/js/core/DraggableList.js' => 'bea6e7f4',
475
475
'rsrc/js/core/Favicon.js' => '1fe2510c',
476
476
'rsrc/js/core/FileUpload.js' => '680ea2c8',
477
477
'rsrc/js/core/Hovercard.js' => '1bd28176',
···
786
786
'phabricator-countdown-css' => '16c52f5c',
787
787
'phabricator-dashboard-css' => 'bc6f2127',
788
788
'phabricator-drag-and-drop-file-upload' => '58dea2fa',
789
-
'phabricator-draggable-list' => '5a13c79f',
789
+
'phabricator-draggable-list' => 'bea6e7f4',
790
790
'phabricator-fatal-config-template-css' => '8f18fa41',
791
791
'phabricator-favicon' => '1fe2510c',
792
792
'phabricator-feed-css' => 'ecd4ec57',
···
1366
1366
'javelin-vector',
1367
1367
'javelin-dom',
1368
1368
),
1369
-
'5a13c79f' => array(
1370
-
'javelin-install',
1371
-
'javelin-dom',
1372
-
'javelin-stratcom',
1373
-
'javelin-util',
1374
-
'javelin-vector',
1375
-
'javelin-magical-init',
1376
-
),
1377
1369
'5c54cbf3' => array(
1378
1370
'javelin-behavior',
1379
1371
'javelin-stratcom',
···
1932
1924
'javelin-dom',
1933
1925
'javelin-util',
1934
1926
'javelin-request',
1927
+
),
1928
+
'bea6e7f4' => array(
1929
+
'javelin-install',
1930
+
'javelin-dom',
1931
+
'javelin-stratcom',
1932
+
'javelin-util',
1933
+
'javelin-vector',
1934
+
'javelin-magical-init',
1935
1935
),
1936
1936
'bee502c8' => array(
1937
1937
'javelin-behavior',
+7
-2
webroot/rsrc/js/core/DraggableList.js
+7
-2
webroot/rsrc/js/core/DraggableList.js
···
297
297
298
298
if (group[ii].getHasInfiniteHeight()) {
299
299
// The math doesn't work out quite right if we actually use
300
-
// Math.Infinity, so approximate infinity as the document height.
301
-
infinity = infinity || JX.Vector.getDocument().y;
300
+
// Math.Infinity, so approximate infinity as the larger of the
301
+
// document height or viewport height.
302
+
if (!infinity) {
303
+
infinity = Math.max(
304
+
JX.Vector.getViewport().y,
305
+
JX.Vector.getDocument().y);
306
+
}
302
307
303
308
rp.y = 0;
304
309
rd.y = infinity;