@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Shuffle project information around on detail page
Summary:
Ref T4007. Fixes T4009. Ref T4008.
- Move blurb to a text section.
- Make it render as remarkup.
- Put policy information and status information in header.
Test Plan: See screenshot.
Reviewers: chad, btrahan
Reviewed By: chad
CC: aran
Maniphest Tasks: T4009, T4007, T4008
Differential Revision: https://secure.phabricator.com/D7373
+20
-4
+18
-2
src/applications/project/controller/PhabricatorProjectProfileController.php
+18
-2
src/applications/project/controller/PhabricatorProjectProfileController.php
···
59
59
60
60
$header = id(new PHUIHeaderView())
61
61
->setHeader($project->getName())
62
-
->setSubheader(phutil_utf8_shorten($profile->getBlurb(), 1024))
62
+
->setUser($user)
63
+
->setPolicyObject($project)
63
64
->setImage($picture);
64
65
66
+
if ($project->getStatus() == PhabricatorProjectStatus::STATUS_ACTIVE) {
67
+
$header->setStatus('oh-ok', '', pht('Active'));
68
+
} else {
69
+
$header->setStatus('policy-noone', '', pht('Archived'));
70
+
}
71
+
72
+
65
73
$actions = $this->buildActionListView($project);
66
-
$properties = $this->buildPropertyListView($project, $actions);
74
+
$properties = $this->buildPropertyListView($project, $profile, $actions);
67
75
68
76
$crumbs = $this->buildApplicationCrumbs();
69
77
$crumbs->addCrumb(
···
253
261
254
262
private function buildPropertyListView(
255
263
PhabricatorProject $project,
264
+
PhabricatorProjectProfile $profile,
256
265
PhabricatorActionListView $actions) {
257
266
$request = $this->getRequest();
258
267
$viewer = $request->getUser();
···
265
274
$view->addProperty(
266
275
pht('Created'),
267
276
phabricator_datetime($project->getDateCreated(), $viewer));
277
+
278
+
$view->addSectionHeader(pht('Description'));
279
+
$view->addTextContent(
280
+
PhabricatorMarkupEngine::renderOneObject(
281
+
id(new PhabricatorMarkupOneOff())->setContent($profile->getBlurb()),
282
+
'default',
283
+
$viewer));
268
284
269
285
return $view;
270
286
}
+2
-2
src/applications/project/controller/PhabricatorProjectProfileEditController.php
+2
-2
src/applications/project/controller/PhabricatorProjectProfileEditController.php
···
127
127
->setOptions($options)
128
128
->setValue($project->getStatus()))
129
129
->appendChild(
130
-
id(new AphrontFormTextAreaControl())
131
-
->setLabel(pht('Blurb'))
130
+
id(new PhabricatorRemarkupControl())
131
+
->setLabel(pht('Description'))
132
132
->setName('blurb')
133
133
->setValue($profile->getBlurb()))
134
134
->appendChild(