recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

PHP 8.5: Fix an invalid null array key in PHUIObjectItemListExample

Summary:
Per https://www.php.net/manual/en/language.types.array.php, regarding array key casts, "Null will be cast to the empty string".
Setting null as an array key is deprecated since PHP 8.5 per https://www.php.net/releases/8.5/en.php: "Using null as an array offset or when calling array_key_exists() is now deprecated. Use an empty string instead."

Test Plan: Go to "Color Icons" on http://phorge.localhost/uiexample/view/PHUIObjectItemListExample/ and look at the first bell icon and its HTML.

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D26510

Andre Klapper db01c969 1534ca2d

+1 -1
+1 -1
src/applications/uiexample/examples/PHUIObjectItemListExample.php
··· 278 278 $list = new PHUIObjectItemListView(); 279 279 280 280 $bar_colors = array( 281 - null => pht('None'), 281 + '' => pht('None'), 282 282 'red' => pht('Red'), 283 283 'orange' => pht('Orange'), 284 284 'yellow' => pht('Yellow'),