recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Allow setup checks to perform writes

Summary:
Fixes T8198. Currently, if the `policy.locked` configuration setting includes a value which is a user PHID, we may perform a cache fill during setup as a side effect of validating it.

Right now, there is no WriteGuard active during setup, because we don't have a Request object yet so we can't actually perform CSRF validation.

Two possible approaches are:

# Prevent the write from occuring.
# Change the code to allow the write.

In the past, I think we've hit similar cases and done (1). However, IIRC those writes were sketchier, more isolated, and easy to remove (I think there was one with PKCS8 keys). This one is pretty legit and not very easy to remove without making a bit of a mess.

There's no techncial reason we can't do (2), we just have to create a no-op WriteGuard for the setup phase.

Test Plan:
- To reproduce this issue: set some value in `policy.locked` to a user PHID, then wipe out profile caches in the database, then restart the webserver.
- Reproduced the issue.
- Added the new dummy write guard, fixed a minor issue with disposal semantics (see D12841).
- Verified this fixed the issue.
- Added a `throw` to the real CSRF validator and performed a real write. Verified I got CSRF-blocked.
- Removed a CSRF token from a form and double-checked that CSRF protection still works.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8198

Differential Revision: https://secure.phabricator.com/D12842

epriestley db1cd658 f233672f

+10 -2
+10 -2
src/aphront/configuration/AphrontApplicationConfiguration.php
··· 62 62 $multimeter->setEventContext('<http-init>'); 63 63 $multimeter->setEventViewer('<none>'); 64 64 65 + // Build a no-op write guard for the setup phase. We'll replace this with a 66 + // real write guard later on, but we need to survive setup and build a 67 + // request object first. 68 + $write_guard = new AphrontWriteGuard('id'); 69 + 65 70 PhabricatorEnv::initializeWebEnvironment(); 66 71 67 72 $multimeter->setSampleRate( ··· 108 113 $application->willBuildRequest(); 109 114 $request = $application->buildRequest(); 110 115 116 + // Now that we have a request, convert the write guard into one which 117 + // actually checks CSRF tokens. 118 + $write_guard->dispose(); 119 + $write_guard = new AphrontWriteGuard(array($request, 'validateCSRF')); 120 + 111 121 // Build the server URI implied by the request headers. If an administrator 112 122 // has not configured "phabricator.base-uri" yet, we'll use this to generate 113 123 // links. ··· 120 130 array( 121 131 'U' => (string)$request->getRequestURI()->getPath(), 122 132 )); 123 - 124 - $write_guard = new AphrontWriteGuard(array($request, 'validateCSRF')); 125 133 126 134 $processing_exception = null; 127 135 try {