@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Move getPrimaryReviewer() to DifferentialRevision
Test Plan: Display revision list both with last reviewer and without.
Reviewers: epriestley, btrahan
Reviewed By: btrahan
CC: aran, Koolvin
Differential Revision: https://secure.phabricator.com/D2495
+9
-10
+2
-10
src/applications/differential/field/specification/reviewers/DifferentialReviewersFieldSpecification.php
+2
-10
src/applications/differential/field/specification/reviewers/DifferentialReviewersFieldSpecification.php
···
140
140
}
141
141
142
142
public function renderValueForRevisionList(DifferentialRevision $revision) {
143
-
$primary_reviewer = $this->getPrimaryReviewer($revision);
143
+
$primary_reviewer = $revision->getPrimaryReviewer();
144
144
if ($primary_reviewer) {
145
145
$other_reviewers = array_flip($revision->getReviewers());
146
146
unset($other_reviewers[$primary_reviewer]);
···
157
157
158
158
public function getRequiredHandlePHIDsForRevisionList(
159
159
DifferentialRevision $revision) {
160
-
$primary_reviewer = $this->getPrimaryReviewer($revision);
160
+
$primary_reviewer = $revision->getPrimaryReviewer();
161
161
if ($primary_reviewer) {
162
162
return array($primary_reviewer);
163
163
}
164
164
return array();
165
-
}
166
-
167
-
private function getPrimaryReviewer(DifferentialRevision $revision) {
168
-
$primary_reviewer = $revision->getLastReviewerPHID();
169
-
if (!$primary_reviewer) {
170
-
$primary_reviewer = head($revision->getReviewers());
171
-
}
172
-
return $primary_reviewer;
173
165
}
174
166
175
167
}
+7
src/applications/differential/storage/revision/DifferentialRevision.php
+7
src/applications/differential/storage/revision/DifferentialRevision.php
···
206
206
return array_keys($this->getUnsubscribed());
207
207
}
208
208
209
+
public function getPrimaryReviewer() {
210
+
if (!$this->lastReviewerPHID) {
211
+
return head($this->getReviewers());
212
+
}
213
+
return $this->lastReviewerPHID;
214
+
}
215
+
209
216
public function loadReviewedBy() {
210
217
$reviewer = null;
211
218