@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add PHUIObjectItemView Status Display to Harbormaster
Summary: Took a short pass here with the new UI, holler if something is TOO EXTREME.
Test Plan:
Tested with manual sleep builds.
{F148693}
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: epriestley, Korvin
Differential Revision: https://secure.phabricator.com/D8901
+21
-5
+17
-5
src/applications/harbormaster/controller/HarbormasterBuildableListController.php
+17
-5
src/applications/harbormaster/controller/HarbormasterBuildableListController.php
···
32
32
$viewer = $this->getRequest()->getUser();
33
33
34
34
$list = new PHUIObjectItemListView();
35
+
$list->setStates(true);
35
36
foreach ($buildables as $buildable) {
36
37
$id = $buildable->getID();
37
38
···
52
53
$item->addIcon('wrench-grey', pht('Manual'));
53
54
}
54
55
55
-
$list->addItem($item);
56
-
57
56
switch ($buildable->getBuildableStatus()) {
58
57
case HarbormasterBuildable::STATUS_PASSED:
59
-
$item->setBarColor('green');
58
+
$item->setState(PHUIObjectItemView::STATE_SUCCESS);
60
59
break;
61
60
case HarbormasterBuildable::STATUS_FAILED:
62
-
$item->setBarColor('red');
61
+
$item->setState(PHUIObjectItemView::STATE_FAIL);
62
+
break;
63
+
case HarbormasterBuildable::STATUS_BUILDING:
64
+
$item->setState(PHUIObjectItemView::STATE_BUILD);
65
+
break;
66
+
default:
67
+
$item->setState(PHUIObjectItemView::STATE_WARN);
63
68
break;
64
69
}
70
+
71
+
$list->addItem($item);
72
+
65
73
}
66
74
67
-
return $list;
75
+
$box = id(new PHUIObjectBoxView())
76
+
->setHeaderText(pht('Buildables'))
77
+
->appendChild($list);
78
+
79
+
return $box;
68
80
}
69
81
70
82
public function buildSideNavView($for_app = false) {
+4
src/view/phui/PHUIObjectItemView.php
+4
src/view/phui/PHUIObjectItemView.php
···
30
30
const STATE_FAIL = 'red';
31
31
const STATE_WARN = 'yellow';
32
32
const STATE_NOTE = 'blue';
33
+
const STATE_BUILD = 'sky';
33
34
34
35
public function setDisabled($disabled) {
35
36
$this->disabled = $disabled;
···
128
129
break;
129
130
case self::STATE_NOTE:
130
131
$fi = 'fa-info-circle blue';
132
+
break;
133
+
case self::STATE_BUILD:
134
+
$fi = 'fa-refresh ph-spin sky';
131
135
break;
132
136
}
133
137
$this->fontIcon = id(new PHUIIconView())