@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix issue reported from github
Summary:
we filter the $actors above such that its possible to have no $actor anymore (if $actor is not a deliverable email address). ergo, make sure we have actor before we start calling methods.
Fixes github issue 403
Test Plan: logic on this one - not 100% sure how to easily reproduce
Reviewers: epriestley
Reviewed By: epriestley
CC: Korvin, epriestley, aran
Differential Revision: https://secure.phabricator.com/D7284
+7
-4
+7
-4
src/applications/metamta/storage/PhabricatorMetaMTAMail.php
+7
-4
src/applications/metamta/storage/PhabricatorMetaMTAMail.php
···
383
383
switch ($key) {
384
384
case 'from':
385
385
$from = $value;
386
-
$actor = $actors[$from];
387
-
388
-
$actor_email = $actor->getEmailAddress();
389
-
$actor_name = $actor->getName();
386
+
$actor_email = null;
387
+
$actor_name = null;
388
+
$actor = idx($actors, $from);
389
+
if ($actor) {
390
+
$actor_email = $actor->getEmailAddress();
391
+
$actor_name = $actor->getName();
392
+
}
390
393
$can_send_as_user = $actor_email &&
391
394
PhabricatorEnv::getEnvConfig('metamta.can-send-as-user');
392
395