@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Phriction - improve workflow for when user entered slug needs to be normalized.
Summary: Encountered this playing with T8402 on my test instance. I think warning the user about adding a trailing "/" is unnecessary so don't do it. I think its confusing to not call out spaces / to lump them in with special characters so call out the sapces.
Test Plan: moved a page around and verified no warning if the slug is missing a "/" as user specified and that a change to spaces is called out
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: epriestley, Korvin
Differential Revision: https://secure.phabricator.com/D13316
+3
-2
+3
-2
src/applications/phriction/controller/PhrictionMoveController.php
+3
-2
src/applications/phriction/controller/PhrictionMoveController.php
···
36
36
// about it.
37
37
if (strlen($v_slug)) {
38
38
$normal_slug = PhabricatorSlug::normalize($v_slug);
39
-
if ($normal_slug !== $v_slug) {
39
+
$no_slash_slug = rtrim($normal_slug, '/');
40
+
if ($normal_slug !== $v_slug && $no_slash_slug !== $v_slug) {
40
41
return $this->newDialog()
41
42
->setTitle(pht('Adjust Path'))
42
43
->appendParagraph(
43
44
pht(
44
45
'The path you entered (%s) is not a valid wiki document '.
45
-
'path. Paths may not contain special characters.',
46
+
'path. Paths may not contain spaces or special characters.',
46
47
phutil_tag('strong', array(), $v_slug)))
47
48
->appendParagraph(
48
49
pht(