recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PHP 8.1 substr(null) in People > Activity Logs

Summary:
When someone tries to log on with invalid credentials, a record is inserted in the phabricator_user.user_log table with action = login-fail.
The session value of this record is set to null in this case.

When you open the People → Activity Logs screen, you will see an exception because of this.

Fixes T15555

Test Plan: Go to https://my.phorge.site/people/logs/ after a login failure and a login success.

Reviewers: O1 Blessed Committers, avivey

Reviewed By: O1 Blessed Committers, avivey

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15555

Differential Revision: https://we.phorge.it/D25351

Steve Campbell dbc101ca 849e18cc

+1 -1
+1 -1
src/applications/people/view/PhabricatorUserLogView.php
··· 36 36 37 37 $rows = array(); 38 38 foreach ($logs as $log) { 39 - $session = substr($log->getSession(), 0, 6); 39 + $session = substr(coalesce($log->getSession(), ''), 0, 6); 40 40 41 41 $actor_phid = $log->getActorPHID(); 42 42 $user_phid = $log->getUserPHID();