@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Display other locations of lint errors
Summary:
Depends on D4392.
I don't plan on adding these to changesets.
Test Plan: Added `$message['locations'] = array(array('line' => 10));` in the code and displayed a revision with lint problems.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D4394
+11
+11
src/applications/differential/field/specification/DifferentialLintFieldSpecification.php
+11
src/applications/differential/field/specification/DifferentialLintFieldSpecification.php
···
116
116
'show' => $show,
117
117
);
118
118
119
+
if (isset($message['locations'])) {
120
+
$locations = array();
121
+
foreach ($message['locations'] as $location) {
122
+
$other_line = idx($location, 'line');
123
+
$locations[] =
124
+
idx($location, 'path', $path).
125
+
($other_line ? ":{$other_line}" : "");
126
+
}
127
+
$description .= "\nOther locations: ".implode(", ", $locations);
128
+
}
129
+
119
130
if (strlen($description)) {
120
131
$rows[] = array(
121
132
'style' => 'details',