@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Reorder "Merge" transaction to make "Close as Duplicate" produce a "[Merged]" email subject
Summary:
Fixes T11782. When you "Close as Duplicate", generate a "[Merged]" email by making the merge the first transaction.
(There are other, more-deterministic ways to do this with action strength, but this is much simpler and I believe it suffices.)
Test Plan: Used "Close as Duplicate", got a "[Merged]" email out of it.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T11782
Differential Revision: https://secure.phabricator.com/D19972
+4
-5
+4
-5
src/applications/maniphest/relationship/ManiphestTaskRelationship.php
+4
-5
src/applications/maniphest/relationship/ManiphestTaskRelationship.php
···
31
31
$subscriber_phids = $this->loadMergeSubscriberPHIDs($tasks);
32
32
33
33
$xactions[] = id(new ManiphestTransaction())
34
+
->setTransactionType(ManiphestTaskMergedFromTransaction::TRANSACTIONTYPE)
35
+
->setNewValue(mpull($tasks, 'getPHID'));
36
+
37
+
$xactions[] = id(new ManiphestTransaction())
34
38
->setTransactionType(PhabricatorTransactions::TYPE_SUBSCRIBERS)
35
39
->setNewValue(array('+' => $subscriber_phids));
36
-
37
-
$xactions[] = id(new ManiphestTransaction())
38
-
->setTransactionType(
39
-
ManiphestTaskMergedFromTransaction::TRANSACTIONTYPE)
40
-
->setNewValue(mpull($tasks, 'getPHID'));
41
40
42
41
return $xactions;
43
42
}