@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Allow MFA enrollment before email verification
Summary: Depends on D18791. Ref T13024. This clears up another initialization order issue, where an unverified address could prevent MFA enrollment.
Test Plan: Configured both verification required and MFA required, clicked "Add Factor", got a dialog for the workflow.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13024
Differential Revision: https://secure.phabricator.com/D18792
+6
+6
src/applications/auth/controller/PhabricatorAuthNeedsMultiFactorController.php
+6
src/applications/auth/controller/PhabricatorAuthNeedsMultiFactorController.php
···
15
15
return false;
16
16
}
17
17
18
+
public function shouldRequireEmailVerification() {
19
+
// Users who haven't verified their email addresses yet can still enroll
20
+
// in MFA.
21
+
return false;
22
+
}
23
+
18
24
public function handleRequest(AphrontRequest $request) {
19
25
$viewer = $this->getViewer();
20
26