recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Paramater type inheritence fix

Summary: These parameters wrongly extend List.

Test Plan:
Used createdStart field for a search - didn't get error about "should be a list".
`git grep 'extends ConduitListParameterType'`.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15881

authored by

Aviv Eyal and committed by
avivey dc6d108b ee74fb4c

+4 -4
+2 -2
src/__phutil_library_map__.php
··· 4437 4437 'ConduitCallTestCase' => 'PhabricatorTestCase', 4438 4438 'ConduitColumnsParameterType' => 'ConduitParameterType', 4439 4439 'ConduitConnectConduitAPIMethod' => 'ConduitAPIMethod', 4440 - 'ConduitEpochParameterType' => 'ConduitListParameterType', 4440 + 'ConduitEpochParameterType' => 'ConduitParameterType', 4441 4441 'ConduitException' => 'Exception', 4442 4442 'ConduitGetCapabilitiesConduitAPIMethod' => 'ConduitAPIMethod', 4443 4443 'ConduitGetCertificateConduitAPIMethod' => 'ConduitAPIMethod', ··· 4461 4461 'ConduitTokenGarbageCollector' => 'PhabricatorGarbageCollector', 4462 4462 'ConduitUserListParameterType' => 'ConduitListParameterType', 4463 4463 'ConduitUserParameterType' => 'ConduitParameterType', 4464 - 'ConduitWildParameterType' => 'ConduitListParameterType', 4464 + 'ConduitWildParameterType' => 'ConduitParameterType', 4465 4465 'ConpherenceColumnViewController' => 'ConpherenceController', 4466 4466 'ConpherenceConduitAPIMethod' => 'ConduitAPIMethod', 4467 4467 'ConpherenceConfigOptions' => 'PhabricatorApplicationConfigOptions',
+1 -1
src/applications/conduit/parametertype/ConduitEpochParameterType.php
··· 1 1 <?php 2 2 3 3 final class ConduitEpochParameterType 4 - extends ConduitListParameterType { 4 + extends ConduitParameterType { 5 5 6 6 protected function getParameterValue(array $request, $key) { 7 7 $value = parent::getParameterValue($request, $key);
+1 -1
src/applications/conduit/parametertype/ConduitWildParameterType.php
··· 1 1 <?php 2 2 3 3 final class ConduitWildParameterType 4 - extends ConduitListParameterType { 4 + extends ConduitParameterType { 5 5 6 6 protected function getParameterTypeName() { 7 7 return 'wild';