recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Add an explicit "null" to a missed `diffusion.branchquery` callsite to fix Diffusion "Branches" page

Summary:
See PHI775. See D19499. Originally, see PHI720.

D19499 broke the standalone "Branches" page for commits. Normally, you reach this by taking these steps:

- View a commit which is contained by 11 or more branches.
- Click the "More Branches..." link in the "Branches" field.
- You should be taken to a list of all branches which contain the commit.

The change to the 'branch' parameter was adjusted in the query that builds the "x, y, z, More Branches..." list, but not on the actual "Branches" list with the full list. Adjust it.

Test Plan:
- Set display limit to 1, viewed a commit on "master" and "stable", clicked "More Branches".
- Before: saw only "master".
- After: saw both "master" and "stable".

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D19532

epriestley dce6dd5d 96a8b89f

+1
+1
src/applications/diffusion/controller/DiffusionBranchTableController.php
··· 22 22 $params = array( 23 23 'offset' => $pager->getOffset(), 24 24 'limit' => $pager->getPageSize() + 1, 25 + 'branch' => null, 25 26 ); 26 27 27 28 $contains = $drequest->getSymbolicCommit();