@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Minor, unlock after discovery exception.
+9
-3
+9
-3
src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php
+9
-3
src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php
···
139
139
$this->pullRepository($repository);
140
140
141
141
if (!$no_discovery) {
142
+
// TODO: It would be nice to discover only if we pulled something,
143
+
// but this isn't totally trivial.
144
+
142
145
$lock_name = get_class($this).':'.$callsign;
143
146
$lock = PhabricatorGlobalLock::newLock($lock_name);
144
147
$lock->lock();
145
148
146
-
// TODO: It would be nice to discover only if we pulled something,
147
-
// but this isn't totally trivial.
148
-
$this->discoverRepository($repository);
149
+
try {
150
+
$this->discoverRepository($repository);
151
+
} catch (Exception $ex) {
152
+
$lock->unlock();
153
+
throw $ex;
154
+
}
149
155
150
156
$lock->unlock();
151
157
}