@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Separate object names from object links in other applications
Summary: Move `Fnn`, `Pnn`, etc., out of the link text so they can be double-clicked to select.
Test Plan: Viewed Paste, Files, Ponder.
Reviewers: chad
Reviewed By: chad
CC: aran
Differential Revision: https://secure.phabricator.com/D5433
+48
-44
+39
-39
src/__celerity_resource_map__.php
+39
-39
src/__celerity_resource_map__.php
···
2996
2996
),
2997
2997
'phabricator-object-item-list-view-css' =>
2998
2998
array(
2999
-
'uri' => '/res/f5dcfaf4/rsrc/css/layout/phabricator-object-item-list-view.css',
2999
+
'uri' => '/res/527ed374/rsrc/css/layout/phabricator-object-item-list-view.css',
3000
3000
'type' => 'css',
3001
3001
'requires' =>
3002
3002
array(
···
3694
3694
), array(
3695
3695
'packages' =>
3696
3696
array(
3697
-
'5515b5b4' =>
3697
+
'2f159460' =>
3698
3698
array(
3699
3699
'name' => 'core.pkg.css',
3700
3700
'symbols' =>
···
3736
3736
34 => 'phabricator-object-item-list-view-css',
3737
3737
35 => 'global-drag-and-drop-css',
3738
3738
),
3739
-
'uri' => '/res/pkg/5515b5b4/core.pkg.css',
3739
+
'uri' => '/res/pkg/2f159460/core.pkg.css',
3740
3740
'type' => 'css',
3741
3741
),
3742
3742
'95ceba95' =>
···
3927
3927
'reverse' =>
3928
3928
array(
3929
3929
'aphront-attached-file-view-css' => '6b1fccc6',
3930
-
'aphront-dialog-view-css' => '5515b5b4',
3931
-
'aphront-error-view-css' => '5515b5b4',
3932
-
'aphront-form-view-css' => '5515b5b4',
3933
-
'aphront-list-filter-view-css' => '5515b5b4',
3934
-
'aphront-pager-view-css' => '5515b5b4',
3935
-
'aphront-panel-view-css' => '5515b5b4',
3936
-
'aphront-table-view-css' => '5515b5b4',
3937
-
'aphront-tokenizer-control-css' => '5515b5b4',
3938
-
'aphront-tooltip-css' => '5515b5b4',
3939
-
'aphront-typeahead-control-css' => '5515b5b4',
3930
+
'aphront-dialog-view-css' => '2f159460',
3931
+
'aphront-error-view-css' => '2f159460',
3932
+
'aphront-form-view-css' => '2f159460',
3933
+
'aphront-list-filter-view-css' => '2f159460',
3934
+
'aphront-pager-view-css' => '2f159460',
3935
+
'aphront-panel-view-css' => '2f159460',
3936
+
'aphront-table-view-css' => '2f159460',
3937
+
'aphront-tokenizer-control-css' => '2f159460',
3938
+
'aphront-tooltip-css' => '2f159460',
3939
+
'aphront-typeahead-control-css' => '2f159460',
3940
3940
'differential-changeset-view-css' => '8aaacd1b',
3941
3941
'differential-core-view-css' => '8aaacd1b',
3942
3942
'differential-inline-comment-editor' => '322728f3',
···
3950
3950
'differential-table-of-contents-css' => '8aaacd1b',
3951
3951
'diffusion-commit-view-css' => 'c8ce2d88',
3952
3952
'diffusion-icons-css' => 'c8ce2d88',
3953
-
'global-drag-and-drop-css' => '5515b5b4',
3953
+
'global-drag-and-drop-css' => '2f159460',
3954
3954
'inline-comment-summary-css' => '8aaacd1b',
3955
3955
'javelin-aphlict' => '95ceba95',
3956
3956
'javelin-behavior' => 'fe22443b',
···
4022
4022
'javelin-util' => 'fe22443b',
4023
4023
'javelin-vector' => 'fe22443b',
4024
4024
'javelin-workflow' => 'fe22443b',
4025
-
'lightbox-attachment-css' => '5515b5b4',
4025
+
'lightbox-attachment-css' => '2f159460',
4026
4026
'maniphest-task-summary-css' => '6b1fccc6',
4027
4027
'maniphest-transaction-detail-css' => '6b1fccc6',
4028
4028
'phabricator-busy' => '95ceba95',
4029
4029
'phabricator-content-source-view-css' => '8aaacd1b',
4030
-
'phabricator-core-buttons-css' => '5515b5b4',
4031
-
'phabricator-core-css' => '5515b5b4',
4032
-
'phabricator-crumbs-view-css' => '5515b5b4',
4033
-
'phabricator-directory-css' => '5515b5b4',
4030
+
'phabricator-core-buttons-css' => '2f159460',
4031
+
'phabricator-core-css' => '2f159460',
4032
+
'phabricator-crumbs-view-css' => '2f159460',
4033
+
'phabricator-directory-css' => '2f159460',
4034
4034
'phabricator-drag-and-drop-file-upload' => '322728f3',
4035
4035
'phabricator-dropdown-menu' => '95ceba95',
4036
4036
'phabricator-file-upload' => '95ceba95',
4037
-
'phabricator-filetree-view-css' => '5515b5b4',
4038
-
'phabricator-flag-css' => '5515b5b4',
4039
-
'phabricator-form-view-css' => '5515b5b4',
4040
-
'phabricator-header-view-css' => '5515b5b4',
4041
-
'phabricator-jump-nav' => '5515b5b4',
4037
+
'phabricator-filetree-view-css' => '2f159460',
4038
+
'phabricator-flag-css' => '2f159460',
4039
+
'phabricator-form-view-css' => '2f159460',
4040
+
'phabricator-header-view-css' => '2f159460',
4041
+
'phabricator-jump-nav' => '2f159460',
4042
4042
'phabricator-keyboard-shortcut' => '95ceba95',
4043
4043
'phabricator-keyboard-shortcut-manager' => '95ceba95',
4044
-
'phabricator-main-menu-view' => '5515b5b4',
4044
+
'phabricator-main-menu-view' => '2f159460',
4045
4045
'phabricator-menu-item' => '95ceba95',
4046
-
'phabricator-nav-view-css' => '5515b5b4',
4046
+
'phabricator-nav-view-css' => '2f159460',
4047
4047
'phabricator-notification' => '95ceba95',
4048
-
'phabricator-notification-css' => '5515b5b4',
4049
-
'phabricator-notification-menu-css' => '5515b5b4',
4050
-
'phabricator-object-item-list-view-css' => '5515b5b4',
4048
+
'phabricator-notification-css' => '2f159460',
4049
+
'phabricator-notification-menu-css' => '2f159460',
4050
+
'phabricator-object-item-list-view-css' => '2f159460',
4051
4051
'phabricator-object-selector-css' => '8aaacd1b',
4052
4052
'phabricator-paste-file-upload' => '95ceba95',
4053
4053
'phabricator-prefab' => '95ceba95',
4054
4054
'phabricator-project-tag-css' => '6b1fccc6',
4055
-
'phabricator-remarkup-css' => '5515b5b4',
4055
+
'phabricator-remarkup-css' => '2f159460',
4056
4056
'phabricator-shaped-request' => '322728f3',
4057
-
'phabricator-side-menu-view-css' => '5515b5b4',
4058
-
'phabricator-standard-page-view' => '5515b5b4',
4057
+
'phabricator-side-menu-view-css' => '2f159460',
4058
+
'phabricator-standard-page-view' => '2f159460',
4059
4059
'phabricator-textareautils' => '95ceba95',
4060
4060
'phabricator-tooltip' => '95ceba95',
4061
-
'phabricator-transaction-view-css' => '5515b5b4',
4062
-
'phabricator-zindex-css' => '5515b5b4',
4063
-
'sprite-apps-large-css' => '5515b5b4',
4064
-
'sprite-gradient-css' => '5515b5b4',
4065
-
'sprite-icon-css' => '5515b5b4',
4066
-
'sprite-menu-css' => '5515b5b4',
4067
-
'syntax-highlighting-css' => '5515b5b4',
4061
+
'phabricator-transaction-view-css' => '2f159460',
4062
+
'phabricator-zindex-css' => '2f159460',
4063
+
'sprite-apps-large-css' => '2f159460',
4064
+
'sprite-gradient-css' => '2f159460',
4065
+
'sprite-icon-css' => '2f159460',
4066
+
'sprite-menu-css' => '2f159460',
4067
+
'syntax-highlighting-css' => '2f159460',
4068
4068
),
4069
4069
));
+2
-2
src/applications/files/controller/PhabricatorFileListController.php
+2
-2
src/applications/files/controller/PhabricatorFileListController.php
···
90
90
$id = $file->getID();
91
91
$phid = $file->getPHID();
92
92
$name = $file->getName();
93
-
$file_name = "F{$id} {$name}";
94
93
$file_uri = $this->getApplicationURI("/info/{$phid}/");
95
94
96
95
$date_created = phabricator_date($file->getDateCreated(), $user);
···
104
103
105
104
$item = id(new PhabricatorObjectItemView())
106
105
->setObject($file)
107
-
->setHeader($file_name)
106
+
->setObjectName("F{$id}")
107
+
->setHeader($name)
108
108
->setHref($file_uri)
109
109
->addAttribute($uploaded)
110
110
->addIcon('none', phabricator_format_bytes($file->getByteSize()));
+4
-1
src/applications/paste/controller/PhabricatorPasteListController.php
+4
-1
src/applications/paste/controller/PhabricatorPasteListController.php
···
97
97
'%s Line(s)',
98
98
new PhutilNumber($line_count));
99
99
100
+
$title = nonempty($paste->getTitle(), pht('(An Untitled Masterwork)'));
101
+
100
102
$item = id(new PhabricatorObjectItemView())
101
-
->setHeader($paste->getFullName())
103
+
->setObjectName('P'.$paste->getID())
104
+
->setHeader($title)
102
105
->setHref('/P'.$paste->getID())
103
106
->setObject($paste)
104
107
->addAttribute(pht('Created %s by %s', $created, $author))
+2
-1
src/applications/ponder/controller/PonderFeedController.php
+2
-1
src/applications/ponder/controller/PonderFeedController.php
···
92
92
$view->setNoDataString(pht('No matching questions.'));
93
93
foreach ($questions as $question) {
94
94
$item = new PhabricatorObjectItemView();
95
-
$item->setHeader('Q'.$question->getID().' '.$question->getTitle());
95
+
$item->setObjectName('Q'.$question->getID());
96
+
$item->setHeader($question->getTitle());
96
97
$item->setHref('/Q'.$question->getID());
97
98
$item->setObject($question);
98
99
+1
-1
webroot/rsrc/css/layout/phabricator-object-item-list-view.css
+1
-1
webroot/rsrc/css/layout/phabricator-object-item-list-view.css