@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add clearer saved search options in ApplicationSearch
Summary: Ref T5307, Makes these buttons a little more clear visually and verbosely. Adds white icons for blue buttons.
Test Plan: Test saving a search, viewing button changes on various form pages / uiexamples.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T5307
Differential Revision: https://secure.phabricator.com/D17305
+34
-16
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
9
9
'names' => array(
10
10
'conpherence.pkg.css' => 'e25569a9',
11
11
'conpherence.pkg.js' => '6249a1cf',
12
-
'core.pkg.css' => '22581832',
12
+
'core.pkg.css' => '022cdeed',
13
13
'core.pkg.js' => '1fa7c0c5',
14
14
'darkconsole.pkg.js' => 'e7393ebb',
15
15
'differential.pkg.css' => '4815647b',
···
134
134
'rsrc/css/phui/phui-basic-nav-view.css' => '3d4b207b',
135
135
'rsrc/css/phui/phui-big-info-view.css' => 'bd903741',
136
136
'rsrc/css/phui/phui-box.css' => '269cbc99',
137
-
'rsrc/css/phui/phui-button.css' => '00ddac15',
137
+
'rsrc/css/phui/phui-button.css' => '7eaff361',
138
138
'rsrc/css/phui/phui-chart.css' => '6bf6f78e',
139
139
'rsrc/css/phui/phui-cms.css' => 'be43c8a8',
140
140
'rsrc/css/phui/phui-comment-form.css' => '48fbd65d',
···
841
841
'phui-basic-nav-view-css' => '3d4b207b',
842
842
'phui-big-info-view-css' => 'bd903741',
843
843
'phui-box-css' => '269cbc99',
844
-
'phui-button-css' => '00ddac15',
844
+
'phui-button-css' => '7eaff361',
845
845
'phui-calendar-css' => '477acfaa',
846
846
'phui-calendar-day-css' => '572b1893',
847
847
'phui-calendar-list-css' => 'eb5c774b',
+7
-4
src/applications/search/controller/PhabricatorApplicationSearchController.php
+7
-4
src/applications/search/controller/PhabricatorApplicationSearchController.php
···
169
169
}
170
170
171
171
$submit = id(new AphrontFormSubmitControl())
172
-
->setValue(pht('Execute Query'));
172
+
->setValue(pht('Search'));
173
173
174
174
if ($run_query && !$named_query && $user->isLoggedIn()) {
175
-
$submit->addCancelButton(
176
-
'/search/edit/'.$saved_query->getQueryKey().'/',
177
-
pht('Save Custom Query...'));
175
+
$save_button = id(new PHUIButtonView())
176
+
->setTag('a')
177
+
->setHref('/search/edit/'.$saved_query->getQueryKey().'/')
178
+
->setText(pht('Save Query'))
179
+
->setIcon('fa-floppy-o');
180
+
$submit->addButton($save_button);
178
181
}
179
182
180
183
// TODO: A "Create Dashboard Panel" action goes here somewhere once
+12
-9
src/view/form/control/AphrontFormSubmitControl.php
+12
-9
src/view/form/control/AphrontFormSubmitControl.php
···
2
2
3
3
final class AphrontFormSubmitControl extends AphrontFormControl {
4
4
5
-
private $cancelButton;
5
+
private $buttons = array();
6
6
7
7
public function addCancelButton($href, $label = null) {
8
8
if (!$label) {
9
9
$label = pht('Cancel');
10
10
}
11
+
$button = id(new PHUIButtonView())
12
+
->setTag('a')
13
+
->setHref($href)
14
+
->setText($label)
15
+
->setColor(PHUIButtonView::GREY);
16
+
$this->addButton($button);
17
+
return $this;
18
+
}
11
19
12
-
$this->cancelButton = phutil_tag(
13
-
'a',
14
-
array(
15
-
'href' => $href,
16
-
'class' => 'button grey',
17
-
),
18
-
$label);
20
+
public function addButton(PHUIButtonView $button) {
21
+
$this->buttons[] = $button;
19
22
return $this;
20
23
}
21
24
···
38
41
39
42
return array(
40
43
$submit_button,
41
-
$this->cancelButton,
44
+
$this->buttons,
42
45
);
43
46
}
44
47