@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Diffusion - upgrade exception error message to include hint to config option
Summary: Fixes T6419. Also, there was a question on T6419 about whether this was in a try catch block and it is... Its not clear to me what happens in the "timeout" case though?
Test Plan: looks nice
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T6419
Differential Revision: https://secure.phabricator.com/D10755
+5
-4
+5
-4
src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php
+5
-4
src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php
···
62
62
try {
63
63
$raw_patch = $this->loadRawPatchText($repository, $commit);
64
64
} catch (Exception $ex) {
65
-
phlog($ex);
66
65
$raw_patch = pht('Unable to generate patch: %s', $ex->getMessage());
67
66
}
68
67
$editor->setRawPatch($raw_patch);
···
99
98
if ($byte_limit && $size > $byte_limit) {
100
99
$pretty_size = phutil_format_bytes($size);
101
100
$pretty_limit = phutil_format_bytes($byte_limit);
102
-
throw new Exception(
103
-
"Patch size of {$pretty_size} exceeds configured byte size limit of ".
104
-
"{$pretty_limit}.");
101
+
throw new Exception(pht(
102
+
'Patch size of %s exceeds configured byte size limit (%s) of %s.',
103
+
$pretty_size,
104
+
$byte_key,
105
+
$pretty_limit));
105
106
}
106
107
107
108
return $raw_diff;