@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Trim transaction overload when converting events from all-day and back
Summary: Closes T8136, Trim transaction overload when converting events from all-day and back
Test Plan: Create new event, save, edit, change to all-day, save, remove all-day flag, save. Feed should not show "end date changed" transaction
Reviewers: #blessed_reviewers, epriestley
Reviewed By: #blessed_reviewers, epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T8136
Differential Revision: https://secure.phabricator.com/D12781
+4
-3
+3
-2
src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
+3
-2
src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
···
51
51
case PhabricatorCalendarEventTransaction::TYPE_CANCEL:
52
52
return $object->getIsCancelled();
53
53
case PhabricatorCalendarEventTransaction::TYPE_ALL_DAY:
54
-
return $object->getIsAllDay();
54
+
return (int)$object->getIsAllDay();
55
55
case PhabricatorCalendarEventTransaction::TYPE_INVITE:
56
56
$map = $xaction->getNewValue();
57
57
$phids = array_keys($map);
···
89
89
case PhabricatorCalendarEventTransaction::TYPE_DESCRIPTION:
90
90
case PhabricatorCalendarEventTransaction::TYPE_CANCEL:
91
91
case PhabricatorCalendarEventTransaction::TYPE_INVITE:
92
+
return $xaction->getNewValue();
92
93
case PhabricatorCalendarEventTransaction::TYPE_ALL_DAY:
93
-
return $xaction->getNewValue();
94
+
return (int)$xaction->getNewValue();
94
95
case PhabricatorCalendarEventTransaction::TYPE_STATUS:
95
96
return (int)$xaction->getNewValue();
96
97
case PhabricatorCalendarEventTransaction::TYPE_START_DATE: