@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Added a 'name' field to the results for harbormaster.build.search endpoint
Summary: Fixes T11642. Added a 'name' field to the results from harbormaster.build.search.
Test Plan: Went to `/conduit/method/harbormaster.build.search/` and ran a search that would yield results (because otherwise there will be nothing there). Noted that there was, in fact, a name in the results.
Reviewers: yelirekim, #blessed_reviewers, epriestley
Reviewed By: yelirekim, #blessed_reviewers, epriestley
Subscribers: epriestley, yelirekim
Maniphest Tasks: T11642
Differential Revision: https://secure.phabricator.com/D16569
+5
+5
src/applications/harbormaster/storage/build/HarbormasterBuild.php
+5
src/applications/harbormaster/storage/build/HarbormasterBuild.php
···
420
420
->setKey('initiatorPHID')
421
421
->setType('phid')
422
422
->setDescription(pht('The person (or thing) that started this build.')),
423
+
id(new PhabricatorConduitSearchFieldSpecification())
424
+
->setKey('name')
425
+
->setType('string')
426
+
->setDescription(pht('The name of this build.')),
423
427
);
424
428
}
425
429
···
433
437
'name' => HarbormasterBuildStatus::getBuildStatusName($status),
434
438
),
435
439
'initiatorPHID' => nonempty($this->getInitiatorPHID(), null),
440
+
'name' => $this->getName(),
436
441
);
437
442
}
438
443