recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix a minor issue in Nuance which could cause the trigger daemon to poll too often

Summary: Ref T10537. Currently, when you have at least two cursors, the daemon can poll too frequently when processing the last source because it never hits the end-of-list condition.

Test Plan:
- Ran `bin/phd debug trigger`.
- Observed huge volumes of output before change as triggers fired as fast as possible.
- Observed reasonable poll frequency after change.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10537

Differential Revision: https://secure.phabricator.com/D15464

epriestley de23ba00 5df5f339

+1 -1
+1 -1
src/infrastructure/daemon/workers/PhabricatorTriggerDaemon.php
··· 411 411 } 412 412 413 413 // If we haven't loaded sources yet, load them first. 414 - if (!$this->nuanceSources) { 414 + if (!$this->nuanceSources && !$this->nuanceCursors) { 415 415 $this->anyNuanceData = false; 416 416 417 417 $sources = id(new NuanceSourceQuery())