@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Always show "X requested review" in mail to stop some undraft mail from being dropped
Summary: Ref T13035. See that task for a description of the issue.
Test Plan:
- Enabled prototypes.
- Disabled all Herald rules that trigger Harbormaster builds.
- Created a new revision.
- Before patch: initial review request email was dropped.
- After patch: initial review request email is sent.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13035
Differential Revision: https://secure.phabricator.com/D18851
+6
+6
src/applications/differential/storage/DifferentialTransaction.php
+6
src/applications/differential/storage/DifferentialTransaction.php
···
111
111
// Don't hide the initial "X added reviewers: ..." transaction during
112
112
// object creation from mail. See T12118 and PHI54.
113
113
return false;
114
+
case DifferentialRevisionRequestReviewTransaction::TRANSACTIONTYPE:
115
+
// Don't hide the initial "X requested review: ..." transaction from
116
+
// mail even when it occurs during creation. We need this transaction
117
+
// to survive so we'll generate mail when revisions immediately leave
118
+
// the draft state. See T13035 for discussion.
119
+
return false;
114
120
}
115
121
116
122
return parent::shouldHideForMail($xactions);