@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Improve timeline rendering for old macros
Summary: This always bugs me when I'm going through `secure` looking for the spiciest macros.
Test Plan: Forced a date to be null, saw reasonable text.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D20453
+6
-1
+6
-1
src/applications/macro/controller/PhabricatorMacroViewController.php
+6
-1
src/applications/macro/controller/PhabricatorMacroViewController.php
···
136
136
$image_uri = $handles[$author_phid]->getImageURI();
137
137
$image_href = $handles[$author_phid]->getURI();
138
138
139
-
$content = pht('Masterfully imagined by %s on %s.', $author, $date);
139
+
if (!$date) {
140
+
$content = pht(
141
+
'Masterfully imagined by %s in ages long past.', $author);
142
+
} else {
143
+
$content = pht('Masterfully imagined by %s on %s.', $author, $date);
144
+
}
140
145
141
146
return id(new PHUIHeadThingView())
142
147
->setImage($image_uri)